Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a new command to list supported algos #14655

Merged
merged 6 commits into from
Jan 17, 2023
Merged

feat: add a new command to list supported algos #14655

merged 6 commits into from
Jan 17, 2023

Conversation

julienrbrt
Copy link
Member

Description

Closes: #8886

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner January 17, 2023 17:20
@github-actions github-actions bot added C:CLI C:Keys Keybase, KMS and HSMs labels Jan 17, 2023
tac0turtle
tac0turtle approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 17, 2023
View reviewed changes
simapp/simd/cmd/testnet.go
@@ -167,7 +177,7 @@
args.chainID, _ = cmd.Flags().GetString(flags.FlagChainID)
args.minGasPrices, _ = cmd.Flags().GetString(server.FlagMinGasPrices)
args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators)
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm)
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
simapp/simd/cmd/testnet.go
@@ -134,7 +144,7 @@
args.nodeDaemonHome, _ = cmd.Flags().GetString(flagNodeDaemonHome)
args.startingIPAddress, _ = cmd.Flags().GetString(flagStartingIPAddress)
args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators)
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm)
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
client/keys/add.go
@@ -113,7 +123,7 @@
outputFormat := ctx.OutputFormat

keyringAlgos, _ := kb.SupportedAlgorithms()
algoStr, _ := cmd.Flags().GetString(flags.FlagKeyAlgorithm)
algoStr, _ := cmd.Flags().GetString(flags.FlagKeyType)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
@julienrbrt julienrbrt merged commit 5233d5e into main Jan 17, 2023
@julienrbrt julienrbrt deleted the julien/key-type branch January 17, 2023 22:24
julienrbrt
julienrbrt commented Jan 17, 2023
View reviewed changes
client/keys/add.go
f.String(flags.FlagKeyType, string(hd.Secp256k1Type), "Key signing algorithm to generate keys for")

// support old flags name for backwards compatibility
cmd.PersistentFlags().SetNormalizeFunc(func(f *pflag.FlagSet, name string) pflag.NormalizedName {
Copy link
Member Author

@julienrbrt julienrbrt Jan 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmd.PersistentFlags() should have been cmd.Flags() and my fat fingers merged from my phone.
I can fix in on some unrelated incoming PR.

julienrbrt
julienrbrt commented Jan 17, 2023
View reviewed changes
client/keys/add.go
f.String(flags.FlagKeyType, string(hd.Secp256k1Type), "Key signing algorithm to generate keys for")

// support old flags name for backwards compatibility
cmd.PersistentFlags().SetNormalizeFunc(func(f *pflag.FlagSet, name string) pflag.NormalizedName {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmd.PersistentFlags() should have been cmd.Flags() and my fat fingers merged from my phone.
I can fix in on unrelated incoming PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing here: https://github.com/cosmos/cosmos-sdk/pull/14652/files#diff-ff89a853b81cbba6ecc824fc56f2e0e6e59f56dd17403b5c8e438fb6dad379b5R84 so we are good.

@julienrbrt julienrbrt mentioned this pull request Jan 17, 2023
Merged
19 tasks
@tac0turtle
Copy link
Member

@Mergifyio backport release/v0.47.x

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2023 •
edited
Loading

backport release/v0.47.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Mar 20, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 20, 2023
@julienrbrt @mergify
feat: add a new command to list supported algos (#14655)
29de940 
(cherry picked from commit 5233d5e)

# Conflicts:
#	CHANGELOG.md
#	simapp/simd/cmd/testnet.go
julienrbrt added a commit that referenced this pull request Mar 20, 2023
@mergify @julienrbrt
feat: add a new command to list supported algos (backport #14655) (#1…
cbef7f3 
…5468)

Co-authored-by: Julien Robert <julien@rbrt.fr>
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@julienrbrt
feat: add a new command to list supported algos (cosmos#14655)
9e0f479
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
C:CLI C:Keys Keybase, KMS and HSMs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new command to list supported algos
2 participants
@julienrbrt @tac0turtle