Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collections): implement pagination #14468

Merged
merged 17 commits into from
Jan 6, 2023
Merged

feat(collections): implement pagination #14468

merged 17 commits into from
Jan 6, 2023

Conversation

testinginprod
Copy link
Contributor

Description

Implements pagination logic for a collection.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod requested a review from a team as a code owner January 3, 2023 15:38
@aaronc aaronc assigned aaronc and unassigned aaronc Jan 3, 2023
alexanderbez
alexanderbez reviewed Jan 5, 2023
View reviewed changes
types/query/collections_pagination.go Show resolved Hide resolved
types/query/collections_pagination.go Outdated Show resolved Hide resolved
types/query/collections_pagination.go Outdated Show resolved Hide resolved
types/query/collections_pagination.go Outdated Show resolved Hide resolved
types/query/collections_pagination.go Outdated Show resolved Hide resolved
types/query/collections_pagination.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@testinginprod testinginprod enabled auto-merge (squash) January 6, 2023 10:14
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

[Cosmos SDK - Collections] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@testinginprod testinginprod merged commit f771f20 into main Jan 6, 2023
@testinginprod testinginprod deleted the tip/collections-pagination branch January 6, 2023 11:08
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@testinginprod
feat(collections): implement pagination (cosmos#14468)
43e9c99 
Co-authored-by: testinginprod <testinginprod@somewhere.idk>
@samricotta samricotta mentioned this pull request May 24, 2023
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

@julienrbrt julienrbrt Awaiting requested review from julienrbrt

Assignees

@alexanderbez alexanderbez

@facundomedica facundomedica

Labels
C:collections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@testinginprod @alexanderbez @aaronc @facundomedica