Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Return error instead of empty values when pruned height is queried #13896

Merged
merged 6 commits into from
Nov 17, 2022
Merged

fix: Return error instead of empty values when pruned height is queried #13896

merged 6 commits into from
Nov 17, 2022

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #12823

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 changed the title fix: Return err instead of empty values when pruned height is queried fix: Return error instead of empty values when pruned height is queried Nov 17, 2022
@likhita-809 likhita-809 marked this pull request as ready for review November 17, 2022 09:14
tac0turtle
tac0turtle approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, we never back ported this, thank you

@tac0turtle tac0turtle merged commit af529b8 into release/v0.45.x Nov 17, 2022
@tac0turtle tac0turtle deleted the likhita/fix-prune-height-query-error branch November 17, 2022 11:34
@faddat faddat mentioned this pull request Mar 23, 2023
Closed
19 tasks
@julienrbrt julienrbrt mentioned this pull request Apr 6, 2023
Merged
@faddat faddat mentioned this pull request Dec 11, 2023
Draft
19 tasks
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@likhita-809 @JeancarloBarrios
fix: Return error instead of empty values when pruned height is queri…
efeee5e 
…ed (cosmos#13896)

* fix: return err instead of empty values when pruned height is queried

* fix tests

* fix more tests

* final fixes

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@likhita-809 @tac0turtle