Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: --dry-run flag not working when using tx cmd #13673

Merged
merged 6 commits into from
Oct 31, 2022
Merged

fix: --dry-run flag not working when using tx cmd #13673

merged 6 commits into from
Oct 31, 2022

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #13202

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review October 27, 2022 08:40
julienrbrt
julienrbrt reviewed Oct 27, 2022
View reviewed changes
client/context.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. (but see #13673 (comment))

@julienrbrt julienrbrt added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Oct 27, 2022
alexanderbez
alexanderbez approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

atheeshp
atheeshp approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

client/context_test.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez merged commit 760acf1 into release/v0.45.x Oct 31, 2022
@alexanderbez alexanderbez deleted the likhita/fix-dry-run branch October 31, 2022 14:53
julienrbrt
julienrbrt reviewed Oct 31, 2022
View reviewed changes
CHANGELOG.md
@@ -48,8 +48,13 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Bug Fixes

* [#13673](https://github.com/cosmos/cosmos-sdk/pull/13673) Fix `--dry-run` flag not working when using tx command.
Copy link
Member

@julienrbrt julienrbrt Oct 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likhita-809, I've missed it but the changelog has been included to the wrong place. Can you put it under unreleased?

@julienrbrt julienrbrt mentioned this pull request Oct 31, 2022
Closed
@likhita-809 likhita-809 mentioned this pull request Oct 31, 2022
Merged
19 tasks
nnkken pushed a commit to likecoin/cosmos-sdk that referenced this pull request Nov 16, 2022
@likhita-809 @nnkken
fix: --dry-run flag not working when using tx cmd (cosmos#13673)
fb56273
@faddat faddat mentioned this pull request Dec 11, 2023
Draft
19 tasks
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@likhita-809 @JeancarloBarrios
fix: --dry-run flag not working when using tx cmd (cosmos#13673)
fe1584f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@anilcse anilcse anilcse approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@atheeshp atheeshp atheeshp approved these changes

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

@amaury1093 amaury1093 Awaiting requested review from amaury1093

Assignees
No one assigned
Labels
C:CLI C:x/auth C:x/bank C:x/feegrant T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@likhita-809 @anilcse @alexanderbez @julienrbrt @atheeshp