-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump go minimum version to go 1.19 #13397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Cosmovisor
Issues and PR related to Cosmovisor
C:orm
C:Rosetta
Issues and PR related to Rosetta
C:Store
Type: Build
Type: CI
labels
Sep 26, 2022
julienrbrt
changed the title
deps: bump go minimum version to go 1.19
build(deps): bump go minimum version to go 1.19
Sep 26, 2022
julienrbrt
commented
Sep 27, 2022
julienrbrt
force-pushed
the
julien/bump-go
branch
from
September 27, 2022 00:07
42385fc
to
c82d944
Compare
Why not fix the double close at the caller side, and bump format version, then all golang versions should work with the new format. |
Waiting for #13400 to rebase. |
alexanderbez
approved these changes
Sep 27, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13397 +/- ##
==========================================
- Coverage 54.33% 54.28% -0.06%
==========================================
Files 640 637 -3
Lines 54816 54601 -215
==========================================
- Hits 29787 29641 -146
+ Misses 22630 22580 -50
+ Partials 2399 2380 -19
|
Wryhder
pushed a commit
to Wryhder/cosmos-sdk
that referenced
this pull request
Oct 26, 2022
ryanchristo
pushed a commit
to regen-network/cosmos-sdk
that referenced
this pull request
Dec 14, 2022
19 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:CLI
C:Cosmovisor
Issues and PR related to Cosmovisor
C:orm
C:Rosetta
Issues and PR related to Rosetta
C:Store
Type: Build
Type: CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #13373
cc @mmsqe
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change