Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): move rollback_test.go to tests/integration #13117

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

kocubinski
Copy link
Member

@kocubinski kocubinski commented Aug 31, 2022

Description

Required for #13110, and is the last reference to simapp outside of tests/. This is an integration test as written, so I've moved it to tests/integration. Had I refactored to depend on x/modules instead of simapp I'd have introduced new dependencies in store on x/ which aren't there now. Therefore keeping the test as-is and moving it makes the most sense to me.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@kocubinski kocubinski requested a review from a team as a code owner August 31, 2022 22:55
@alexanderbez alexanderbez enabled auto-merge (squash) September 1, 2022 06:22
@alexanderbez alexanderbez merged commit d638ca3 into main Sep 1, 2022
@alexanderbez alexanderbez deleted the kocubinski/mv-store-test branch September 1, 2022 07:32
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants