-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: List HRP prefixes in Bech32 addresses #13064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Utack, Could we get a changelog entry please.
Codecov Report
@@ Coverage Diff @@
## main #13064 +/- ##
==========================================
- Coverage 55.87% 53.21% -2.67%
==========================================
Files 646 645 -1
Lines 54895 55188 +293
==========================================
- Hits 30675 29366 -1309
- Misses 21762 23475 +1713
+ Partials 2458 2347 -111
|
@rnbguy is there anything you need from us to finish this? |
@marbar3778 I added a changelog entry. I am not sure about tests and code coverage. I don't find any test for other |
We just need to resolve conflicts and then mark this ready for review and then we can merge 👍 |
Description
Closes: #13060
Adds a new subcommand
simd debug prefixes
to list prefixes used as HRP in Bech32 addresses.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change