Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent nil DecCoin creation when converting Coins to DecCoins #12903

Merged
merged 5 commits into from
Aug 11, 2022

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Aug 11, 2022

Description

Closes: #12902


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@yun-yeo yun-yeo requested a review from a team as a code owner August 11, 2022 07:34
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #12903 (761b27a) into main (4fe7797) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12903      +/-   ##
==========================================
- Coverage   55.87%   55.87%   -0.01%     
==========================================
  Files         646      646              
  Lines       54895    54898       +3     
==========================================
+ Hits        30675    30676       +1     
  Misses      21762    21762              
- Partials     2458     2460       +2     
Impacted Files Coverage Δ
types/dec_coin.go 98.41% <50.00%> (-0.79%) ⬇️
x/group/keeper/keeper.go 56.29% <0.00%> (+0.39%) ⬆️

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@alexanderbez
Copy link
Contributor

@YunSuk-Yeo, sorry do you mind addressing the merge conflict prior to merge?

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 11, 2022
@mergify mergify bot merged commit cdbeb90 into cosmos:main Aug 11, 2022
@yun-yeo yun-yeo deleted the bugfix/coins-to-deccoins-nil-creation branch August 12, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewDecFromCoins can make nil item in the result DecCoins
3 participants