feat: add message index event attribute to authz message execution #12668

alexanderbez · 2022-07-21T08:38:23Z

Description

It's impossible currently for operators or clients to understand what events emitted from messages executed via MsgExec correspond to exactly what messages. This PR adds a message index attribute to each event emitted by a message via MsgExec.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

tac0turtle

utACK

…-sdk into bez/authz-msg-events-index

julienrbrt

lgtm!

julienrbrt · 2022-07-21T11:14:11Z

x/authz/keeper/keeper.go

-			sdkEvents = append(sdkEvents, sdk.Event(events[i]))
+		for _, event := range events {
+			e := event
+			e.Attributes = append(e.Attributes, abci.EventAttribute{Key: "authz_msg_index", Value: strconv.Itoa(i)})


If we move back to normal event, we should define this in an events.go as AttributeKeyMsgIndex or smth. Now we have this module combining TypedEvent and “Legacy” Events while the documentation state otherwise: https://docs.cosmos.network/v0.46/modules/authz/04_events.html

agere. Im more inclined to revert the changes and then move to it later but need to make a team call on this.

Huh? Where is there typed events used here?

Not in your code, but here https://github.com/cosmos/cosmos-sdk/blob/main/x/authz/keeper/keeper.go#L195-L199 and there https://github.com/cosmos/cosmos-sdk/blob/main/x/authz/keeper/keeper.go#L221-L225

ahh yeah, but we're just adding an attribute here though. What do you want to change?

I was just noticing the usage of two types of events in the authz module :)

…12668) ## Description It's impossible currently for operators or clients to understand what events emitted from messages executed via `MsgExec` correspond to exactly what messages. This PR adds a message index attribute to each event emitted by a message via `MsgExec`. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit afab2f3) # Conflicts: # CHANGELOG.md

…12668) ## Description It's impossible currently for operators or clients to understand what events emitted from messages executed via `MsgExec` correspond to exactly what messages. This PR adds a message index attribute to each event emitted by a message via `MsgExec`. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit afab2f3) # Conflicts: # CHANGELOG.md # x/authz/keeper/keeper.go # x/authz/keeper/msg_server.go

…ackport #12668) (#12672)

…ackport #12668) (#12673)

…ackport cosmos#12668) (cosmos#12673)

* Update tag.yml * fix: update index of crisis invariant check logs (backport cosmos#12208) (cosmos#12210) * fix: update index of crisis invariant check logs (cosmos#12208) ## Description the info log messages describing invariant checks use the index to state progress (eg. `asserting crisis invariants inv=0/15`). this simple change makes them 1-indexed (eg. `asserting crisis invariants inv=1/15`). example before: <img width="374" alt="Screen Shot 2022-06-09 at 12 06 58 PM" src="https://user-images.githubusercontent.com/14897503/172925006-8810706c-0948-4e36-85b8-22813ccc9311.png"> Closes: #XXXX --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - N/A - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - N/A - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - N/A - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - N/A - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - N/A - [x] updated the relevant documentation or specification - N/A - [x] reviewed "Files changed" and left comments if necessary - N/A - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 907df32) # Conflicts: # CHANGELOG.md * fix conflict Co-authored-by: Robert Pirtle <Astropirtle@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: Refactor GetLastCompletedUpgrade [v0.45.x] (cosmos#12264) * fix: defaultGenTxGas to 10 times (cosmos#12314) * fix: edit validator bug from cli (cosmos#12317) * chore: update release notes (cosmos#12377) * feat: add query.GenericFilteredPaginated (backport cosmos#12253) (cosmos#12371) * fix: update x/mint parameter validation (backport cosmos#12384) (cosmos#12396) * chore: optimize get last completed upgrade (cosmos#12268) * feat: improve GetLastCompletedUpgrade * rename * use var block * fix: Simulation is not deterministic due to GenTx (backport cosmos#12374) (cosmos#12437) * fix: use go install instead of go get in makefile (cosmos#12435) * chore: fumpt sdk v45 series cosmos#12442 * feat: Move AppModule.BeginBlock and AppModule.EndBlock to extension interfaces (backport cosmos#12603) (cosmos#12638) * feat: Move AppModule.BeginBlock and AppModule.EndBlock to extension interfaces (cosmos#12603) ## Description Most modules right now have a no-op for AppModule.BeginBlock and AppModule.EndBlock. We should move these methods off the AppModule interface so we have less deadcode, and instead move them to extension interfaces. 1. I added `BeginBlockAppModule` and `EndBlockAppModule` interface. 2. Remove the dead-code from modules that do no implement them 3. Add type casting in the the module code to use the new interface Closes: cosmos#12462 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit b65f3fe) # Conflicts: # CHANGELOG.md # x/authz/module/module.go # x/group/module/module.go # x/nft/module/module.go # x/params/module.go # x/slashing/module.go # x/upgrade/module.go * remove conflicts * remove conflicts * remove unused modules Co-authored-by: Sishir Giri <sishirg27@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * feat: add message index event attribute to authz message execution (backport cosmos#12668) (cosmos#12673) * chore(store): upgrade iavl to v0.19.0 (backport cosmos#12626) (cosmos#12697) * feat: Add `GetParamSetIfExists` to prevent panic on breaking param changes (cosmos#12724) * feat: Add convenience method for constructing key to access account's balance for a given denom (backport cosmos#12674) (cosmos#12745) * feat: Add convenience method for constructing key to access account's balance for a given denom (cosmos#12674) This PR adds a convenience method for constructing the key necessary to query for the account's balance of a given denom. I ran into this issue since we are using ABCI query now to perform balance requests because we are also requesting merkle proofs for the returned balance [here](https://github.com/celestiaorg/celestia-node/pull/911/files#diff-0ee31f5a7bd88e9f758e6bebdf3ee36365519e55a451098d9638c39afe5eac42R144). It would be nice to have a definitive convenience method for constructing the key. [Ref.](github.com/celestiaorg/celestia-node/pull/911) (cherry picked from commit a1777a8) # Conflicts: # CHANGELOG.md # x/bank/legacy/v043/store.go # x/bank/types/keys.go * Update CHANGELOG.md * fix conflict Co-authored-by: rene <41963722+renaynay@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com> * chore: bump tm in 0.45.x (cosmos#12784) * bump tendermint version * add changelog entry * replace on jhump * updates * updates * updates Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com> * chore: 0.45.7 changelog prep (cosmos#12821) * prepare for release * modify release notes * chore: migrate from registry to delegation keeper Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Robert Pirtle <Astropirtle@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: HaeSung <hea9549.github@gmail.com> Co-authored-by: likhita-809 <78951027+likhita-809@users.noreply.github.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: Adu <foriteration@gmail.com> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: Sishir Giri <sishirg27@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: rene <41963722+renaynay@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>

…ackport cosmos#12668) (cosmos#12673)

…ackport cosmos#12668) (cosmos#12672)

updates

60a8749

alexanderbez added backport/0.45.x backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release labels Jul 21, 2022

github-actions bot added the C:x/authz label Jul 21, 2022

alexanderbez added 3 commits July 21, 2022 16:39

updates

d22020d

updates

cb098e1

updates

ea90ff9

alexanderbez marked this pull request as ready for review July 21, 2022 08:45

alexanderbez requested a review from a team as a code owner July 21, 2022 08:45

Merge branch 'main' into bez/authz-msg-events-index

2654290

tac0turtle approved these changes Jul 21, 2022

View reviewed changes

alexanderbez and others added 6 commits July 21, 2022 17:13

updates

535a317

Merge branch 'bez/authz-msg-events-index' of github.com:cosmos/cosmos…

694fa55

…-sdk into bez/authz-msg-events-index

updates

69a499d

updates

27ff388

Merge branch 'main' into bez/authz-msg-events-index

8824e7d

Merge branch 'main' into bez/authz-msg-events-index

2e45553

julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 21, 2022

julienrbrt approved these changes Jul 21, 2022

View reviewed changes

mergify bot merged commit afab2f3 into main Jul 21, 2022

mergify bot deleted the bez/authz-msg-events-index branch July 21, 2022 11:38

mergify bot mentioned this pull request Jul 21, 2022

feat: add message index event attribute to authz message execution (backport #12668) #12672

Merged

mergify bot mentioned this pull request Jul 21, 2022

feat: add message index event attribute to authz message execution (backport #12668) #12673

Merged

alexanderbez pushed a commit that referenced this pull request Jul 21, 2022

feat: add message index event attribute to authz message execution (b…

2df7ced

…ackport #12668) (#12672)

alexanderbez pushed a commit that referenced this pull request Jul 22, 2022

feat: add message index event attribute to authz message execution (b…

4eec00f

…ackport #12668) (#12673)

randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022

feat: add message index event attribute to authz message execution (b…

47a27b3

…ackport cosmos#12668) (cosmos#12673)

ryanchristo mentioned this pull request Feb 9, 2023

Allow unknown fields when parsing typed events #14983

Closed

faddat mentioned this pull request Dec 11, 2023

chore: update to v0.45.16 cudoventures/cosmos-sdk#16

Draft

19 tasks

JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024

feat: add message index event attribute to authz message execution (b…

f594924

…ackport cosmos#12668) (cosmos#12673)

JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024

feat: add message index event attribute to authz message execution (b…

39debbf

…ackport cosmos#12668) (cosmos#12672)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add message index event attribute to authz message execution #12668

feat: add message index event attribute to authz message execution #12668

alexanderbez commented Jul 21, 2022

tac0turtle left a comment

julienrbrt left a comment

julienrbrt Jul 21, 2022 •

edited

Loading

tac0turtle Jul 21, 2022

alexanderbez Jul 21, 2022

julienrbrt Jul 21, 2022 •

edited

Loading

alexanderbez Jul 22, 2022

julienrbrt Jul 25, 2022

feat: add message index event attribute to authz message execution #12668

feat: add message index event attribute to authz message execution #12668

Conversation

alexanderbez commented Jul 21, 2022

Description

Author Checklist

Reviewers Checklist

tac0turtle left a comment

Choose a reason for hiding this comment

julienrbrt left a comment

Choose a reason for hiding this comment

julienrbrt Jul 21, 2022 • edited Loading

Choose a reason for hiding this comment

tac0turtle Jul 21, 2022

Choose a reason for hiding this comment

alexanderbez Jul 21, 2022

Choose a reason for hiding this comment

julienrbrt Jul 21, 2022 • edited Loading

Choose a reason for hiding this comment

alexanderbez Jul 22, 2022

Choose a reason for hiding this comment

julienrbrt Jul 25, 2022

Choose a reason for hiding this comment

julienrbrt Jul 21, 2022 •

edited

Loading

julienrbrt Jul 21, 2022 •

edited

Loading