Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate x/params usage in x/bank #12630

Merged
merged 13 commits into from
Jul 20, 2022
Merged

feat: deprecate x/params usage in x/bank #12630

merged 13 commits into from
Jul 20, 2022

Conversation

julienrbrt
Copy link
Member

Description

Closes: #12284

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt linked an issue Jul 19, 2022 that may be closed by this pull request
migrate bank to not use param module #12284
Closed
2 tasks
@julienrbrt julienrbrt force-pushed the julien/migrate-bank-params branch 2 times, most recently from 72fdfb3 to e8fe5a9 Compare July 19, 2022 11:48
@julienrbrt julienrbrt marked this pull request as ready for review July 19, 2022 13:06
@julienrbrt julienrbrt requested a review from a team as a code owner July 19, 2022 13:06
tac0turtle
tac0turtle approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clean up

cool-develope
cool-develope approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@cool-develope cool-develope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 19, 2022
@julienrbrt
Copy link
Member Author

Fixing the migrations right now...

@tac0turtle tac0turtle removed the A:automerge Automatically merge PR once all prerequisites pass. label Jul 19, 2022
alexanderbez
alexanderbez previously requested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @julienrbrt 👏

x/bank/keeper/send.go Outdated Show resolved Hide resolved
x/bank/module.go Show resolved Hide resolved
x/bank/types/msgs.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #12630 (c68734b) into main (eee23d9) will decrease coverage by 0.12%.
The diff coverage is 66.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12630      +/-   ##
==========================================
- Coverage   65.29%   65.17%   -0.13%     
==========================================
  Files         693      693              
  Lines       71607    70805     -802     
==========================================
- Hits        46758    46145     -613     
+ Misses      22236    22088     -148     
+ Partials     2613     2572      -41
Impacted Files Coverage Δ
x/auth/keeper/keeper.go 69.72% <ø> (ø)
x/bank/keeper/genesis.go 74.28% <0.00%> (-5.72%) ⬇️
x/bank/migrations/v2/json.go 100.00% <ø> (ø)
x/bank/migrations/v2/keys.go 12.50% <ø> (ø)
x/bank/migrations/v3/keys.go 100.00% <ø> (ø)
x/bank/migrations/v4/gen_state.go 100.00% <ø> (ø)
x/bank/types/keys.go 100.00% <ø> (ø)
x/bank/types/params.go 84.48% <ø> (-1.68%) ⬇️
x/bank/types/params_legacy.go 0.00% <0.00%> (ø)
x/distribution/module.go 57.42% <ø> (ø)
... and 19 more

@alexanderbez alexanderbez merged commit a5d5461 into main Jul 20, 2022
@alexanderbez alexanderbez deleted the julien/migrate-bank-params branch July 20, 2022 22:58
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@julienrbrt
feat: deprecate x/params usage in x/bank (cosmos#12630)
7c6c2df
@coderabbitai coderabbitai bot mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@cool-develope cool-develope cool-develope approved these changes

@amaury1093 amaury1093 Awaiting requested review from amaury1093

Assignees
No one assigned
Labels
C:x/auth C:x/bank C:x/crisis C:x/distribution distribution module related C:x/genutil genutil module issues Type: ADR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate bank to not use param module
4 participants
@julienrbrt @alexanderbez @tac0turtle @cool-develope