Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove all RegisterRESTRoutes #11797

Merged
merged 4 commits into from
Apr 27, 2022
Merged

fix: remove all RegisterRESTRoutes #11797

merged 4 commits into from
Apr 27, 2022

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Apr 27, 2022 •
edited
Loading

Description

Closes: #11739

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

alexanderbez
alexanderbez approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HELL YEAH!

ValarDragon
ValarDragon approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!!!!

@alexanderbez alexanderbez merged commit 9565600 into cosmos:main Apr 27, 2022
@alexanderbez alexanderbez mentioned this pull request May 3, 2022
Closed
4 tasks
@fadeev fadeev mentioned this pull request Aug 8, 2022
Closed
@tkxkd0159 tkxkd0159 mentioned this pull request Oct 17, 2022
Closed
tbruyelle added a commit to tbruyelle/interchain-security that referenced this pull request Apr 12, 2023
@tbruyelle
remove legacy querier LCD/REST
49e7e99 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to tbruyelle/interchain-security that referenced this pull request Apr 12, 2023
@tbruyelle
remove legacy querier LCD/REST
04b4011 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to tbruyelle/interchain-security that referenced this pull request Apr 12, 2023
@tbruyelle
remove legacy querier LCD/REST
a70b53f 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to allinbits/interchain-security that referenced this pull request Apr 12, 2023
@tbruyelle
remove legacy querier LCD/REST
178c926 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to allinbits/interchain-security that referenced this pull request Apr 13, 2023
@tbruyelle
remove legacy querier LCD/REST
e732248 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to tbruyelle/interchain-security that referenced this pull request Apr 13, 2023
@tbruyelle
remove legacy querier LCD/REST
6a8a781 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to tbruyelle/interchain-security that referenced this pull request Apr 13, 2023
@tbruyelle
remove legacy querier LCD/REST
d6a300e 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to tbruyelle/interchain-security that referenced this pull request Apr 13, 2023
@tbruyelle
remove legacy querier LCD/REST
74a5790 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to tbruyelle/interchain-security that referenced this pull request Apr 13, 2023
@tbruyelle
remove legacy querier LCD/REST
5ff7189 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to tbruyelle/interchain-security that referenced this pull request Apr 13, 2023
@tbruyelle
remove legacy querier LCD/REST
d965163 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to tbruyelle/interchain-security that referenced this pull request Apr 13, 2023
@tbruyelle
remove legacy querier LCD/REST
aa2d700 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to tbruyelle/interchain-security that referenced this pull request Apr 13, 2023
@tbruyelle
remove legacy querier LCD/REST
194247f 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to allinbits/interchain-security that referenced this pull request Apr 14, 2023
@tbruyelle
remove legacy querier LCD/REST
ffe180d 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to allinbits/interchain-security that referenced this pull request Apr 14, 2023
@tbruyelle
remove legacy querier LCD/REST
e058177 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to allinbits/interchain-security that referenced this pull request Apr 17, 2023
@tbruyelle
remove legacy querier LCD/REST
3ff101e 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to allinbits/interchain-security that referenced this pull request Apr 21, 2023
@tbruyelle
remove legacy querier LCD/REST
8329bc3 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
tbruyelle added a commit to allinbits/interchain-security that referenced this pull request Apr 25, 2023
@tbruyelle
remove legacy querier LCD/REST
27b4776 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@facundomedica
fix: remove all RegisterRESTRoutes (cosmos#11797)
5fc75ec
tbruyelle added a commit to allinbits/interchain-security that referenced this pull request May 22, 2023
@tbruyelle
Finish legacy querier LCD/REST cleaning
de0fc66 
https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797
MSalopek pushed a commit to cosmos/interchain-security that referenced this pull request May 22, 2023
@tbruyelle
chore: sdk47 post upgrade cleanup (#970)
1bb8d39 
* Finish legacy querier LCD/REST cleaning

https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#appmodule-interface
cosmos/cosmos-sdk#9594
cosmos/cosmos-sdk#11797

* Finish simulation migration

https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/UPGRADING.md#simulation

* Replace usage of deprecated gov method

* Remove duplicate ante.DeductFeeDecorator
@LampardNguyen234 LampardNguyen234 mentioned this pull request Aug 15, 2023
Merged
@JimLarson JimLarson mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@ValarDragon ValarDragon ValarDragon approved these changes

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

Assignees

@amaury1093 amaury1093

@likhita-809 likhita-809

Labels
C:x/auth C:x/authz C:x/bank C:x/capability C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/slashing C:x/staking C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove RegisterRESTRoutes from AppModuleBasic
5 participants
@facundomedica @alexanderbez @ValarDragon @amaury1093 @likhita-809