-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): home flag gets ignored when running help #11645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just tweaks to tests and the simapp CLI it seems?
Correct, flags weren't parsed ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a nit
@julienrbrt could you fix the conflicts? ty |
3f6d793
to
7eca37b
Compare
Codecov Report
@@ Coverage Diff @@
## master #11645 +/- ##
=======================================
Coverage 65.92% 65.93%
=======================================
Files 667 667
Lines 70462 70462
=======================================
+ Hits 46454 46458 +4
+ Misses 21310 21307 -3
+ Partials 2698 2697 -1
|
Description
Closes: #11508
--home
flag when running help for transaction and queries--node
flag exists. (WIP tbd if done here or in follow-up)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change