Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): home flag gets ignored when running help #11645

Merged
merged 5 commits into from
Apr 21, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Apr 14, 2022

Description

Closes: #11508

  • Consider --home flag when running help for transaction and queries
  • Do not create a folder when making queries, but ensure an environment variable / configuration folder / --node flag exists. (WIP tbd if done here or in follow-up)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt linked an issue Apr 14, 2022 that may be closed by this pull request
4 tasks
@github-actions github-actions bot added the C:CLI label Apr 14, 2022
@julienrbrt julienrbrt marked this pull request as ready for review April 19, 2022 16:14
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just tweaks to tests and the simapp CLI it seems?

@julienrbrt
Copy link
Member Author

This is just tweaks to tests and the simapp CLI it seems?

Correct, flags weren't parsed (DisableFlagParsing was true), and TestHomeFlagRegistration tests that it does now.

Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a nit

CHANGELOG.md Outdated Show resolved Hide resolved
@blushi
Copy link
Contributor

blushi commented Apr 21, 2022

@julienrbrt could you fix the conflicts? ty

@julienrbrt julienrbrt force-pushed the julien/11508-homedir-when-queries branch from 3f6d793 to 7eca37b Compare April 21, 2022 07:48
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #11645 (7eca37b) into master (ec3644f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11645   +/-   ##
=======================================
  Coverage   65.92%   65.93%           
=======================================
  Files         667      667           
  Lines       70462    70462           
=======================================
+ Hits        46454    46458    +4     
+ Misses      21310    21307    -3     
+ Partials     2698     2697    -1     
Impacted Files Coverage Δ
simapp/simd/cmd/root.go 72.41% <100.00%> (ø)
client/cmd.go 57.73% <0.00%> (+2.06%) ⬆️

@alexanderbez alexanderbez merged commit 2c94c2e into master Apr 21, 2022
@alexanderbez alexanderbez deleted the julien/11508-homedir-when-queries branch April 21, 2022 13:27
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home flag gets ignored when running help
4 participants