-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add RegisterLegacyAminoCodec for authz/feegrant #11214
Conversation
Just a reminder: there is also the need to implement Amino serialization for the |
msg = &authz.MsgExec{Grantee: "cosmos1def", Msgs: []*cdctypes.Any{msgSendAny}} | ||
tx.Msgs = []sdk.Msg{msg} | ||
require.Equal(t, | ||
`{"account_number":"1","chain_id":"foo","fee":{"amount":[],"gas":"0"},"memo":"memo","msgs":[{"type":"cosmos-sdk/authz/MsgExec","value":{"grantee":"cosmos1def","msgs":[{"amount":[],"from_address":"cosmos1ghi","to_address":"cosmos1jkl"}]}}],"sequence":"1","timeout_height":"1"}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: for nested Msgs, Amino doesn't show their type
/value
pair. That's because we use a local ModuleCdc to do msg.GetSignBytes, and this local ModuleCdc isn't aware of other modules' amino registrations. I think it's fine, as long as the top-level Msg has a type/value.
@RiccardoM Oh yeah, that sounds good! I have some other work to do on gov/group, so would love if you can finish this PR. (Feel free to push here, or close it and open a new one if you want) |
Description
Closes: #11190
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change