feat: include transactions in QueryBlockByHeight #10880

technicallyty · 2022-01-05T00:45:37Z

Description

Closes: #3729

adds a new query to the tx service in Auth, which gets block information + decoded txs
added a new function to get the protoBlock from the node.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

x/gov/types/v1beta1/gov.pb.go

client/grpc/tmservice/service.go

technicallyty · 2022-01-05T21:12:52Z

x/auth/client/testutil/suite.go

-	s.Require().NoError(s.network.WaitForNextBlock())
+	height, err := s.network.LatestHeight()
+	s.Require().NoError(err)
+	_, err = s.network.WaitForHeight(height + 2) // this test fails unless we wait a couple blocks for some reason?


really odd side effect form this PR - had to make this test wait a couple blocks, else it fails with an error of not being able to find the tx related to the hash passed in...

proto/cosmos/base/tendermint/v1beta1/query.proto

client/grpc/tmservice/service.go

proto/cosmos/base/tendermint/v1beta1/query.proto

amaury1093 · 2022-01-11T10:21:03Z

proto/cosmos/base/tendermint/v1beta1/query.proto

@@ -7,6 +7,7 @@ import "tendermint/p2p/types.proto";
 import "tendermint/types/block.proto";
 import "tendermint/types/types.proto";
 import "cosmos/base/query/v1beta1/pagination.proto";
+import "cosmos/tx/v1beta1/tx.proto";


one question I have is that the tmservice is meant to be a simple proxy to TM, and not app-specific. I'm not sure it should do tx decoding.

For example, the /txs endpoint to fetch txs, exposed by tendermint, is not in this tmservice, but in the Tx service. That's imo the service that decodes txs. I'm wondering if we shouldn't create a new GetBlockWithTxs there. (it's also where the protoTxProvider is currently used).

any thoughts @alexanderbez @technicallyty ?

Yeah I agree here @AmauryM. I don't think we should be adding custom business logic to TM proxy endpoints. I think that's a good point.

yeah i was thinking this as well. maybe a solution could be to add a query string to the request for decoding, something like: GET block/{height}?decode_txs=true?

pinging here - any thoughts on previous comment? @alexanderbez @AmauryM

No I don't think we should modify Tendermint proxy queries. This should be an entirely new query/route. I believe this is what @AmauryM was suggesting?

Yeah, same, I think tx.Tx should not appear in this query.proto file.

tac0turtle · 2022-02-11T11:07:14Z

bump on this. any chance we can get this in the 0.46 release @technicallyty

technicallyty · 2022-02-16T01:32:19Z

bump on this. any chance we can get this in the 0.46 release @technicallyty

heya, i was considering if this PR really makes sense. I was looking into the tx proto's and i wasn't sure if it really makes sense to include block information here. i think it makes the most sense to just suggest to users to do the /txs?tx.height={height} query.

but if there's disagreement there i can proceed with this PR

amaury1093 · 2022-02-16T09:57:41Z

The TxService == TmService + tx decoding, so IMO it makes more sense to put in the TxService. If we call it GetBlockWithTxs I guess it's fine.

codecov · 2022-02-16T21:05:09Z

Codecov Report

Merging #10880 (85738c2) into master (56af6a7) will decrease coverage by 0.06%.
The diff coverage is 63.88%.

❗ Current head 85738c2 differs from pull request most recent head 25e1c3e. Consider uploading reports for the commit 25e1c3e to get more accurate results

@@            Coverage Diff             @@
##           master   #10880      +/-   ##
==========================================
- Coverage   66.07%   66.00%   -0.07%     
==========================================
  Files         662      659       -3     
  Lines       68217    68007     -210     
==========================================
- Hits        45071    44890     -181     
+ Misses      20527    20509      -18     
+ Partials     2619     2608      -11

Impacted Files	Coverage Δ
client/grpc/tmservice/block.go	`52.63% <50.00%> (-4.52%)`	⬇️
x/auth/tx/service.go	`69.69% <66.10%> (-2.01%)`	⬇️
client/grpc/tmservice/service.go	`67.14% <100.00%> (+0.93%)`	⬆️
x/authz/codec.go	`0.00% <0.00%> (-44.00%)`	⬇️
x/slashing/types/codec.go	`50.00% <0.00%> (-12.50%)`	⬇️
x/authz/msgs.go	`51.61% <0.00%> (-10.49%)`	⬇️
x/gov/types/v1beta2/codec.go	`44.44% <0.00%> (-10.11%)`	⬇️
x/evidence/types/codec.go	`47.05% <0.00%> (-10.09%)`	⬇️
x/gov/types/v1beta1/codec.go	`36.00% <0.00%> (-8.83%)`	⬇️
x/distribution/types/codec.go	`41.66% <0.00%> (-8.34%)`	⬇️
... and 14 more

technicallyty · 2022-02-16T21:08:54Z

okay i've implemented the endpoint in the tx service w tests. r4r now @AmauryM @marbar3778

amaury1093

lgtm, I also think pagination is useful here

x/auth/tx/service.go

proto/cosmos/tx/v1beta1/service.proto

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

technicallyty · 2022-02-22T03:45:30Z

added quite a bit of code for the pagination stuff. Normally I just pass the pagination to the query but with the way this query works, I had to do it sorta manually...

would appreciate another round of reviews due to the amount of logic added here! @AmauryM @marbar3778

tac0turtle

lgtm

amaury1093

lgtm, small nits left

Feel free to automerge at will.

x/auth/tx/service.go

proto/cosmos/tx/v1beta1/service.proto

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

## Description Closes: #3729 - adds a new query to the tx service in Auth, which gets block information + decoded txs - added a new function to get the protoBlock from the node. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit dd65ef8) # Conflicts: # CHANGELOG.md # api/cosmos/group/v1beta1/types.pulsar.go # api/cosmos/tx/v1beta1/service.pulsar.go # api/cosmos/tx/v1beta1/service_grpc.pb.go # client/grpc/tmservice/block.go # testutil/testdata_pulsar/query.pulsar.go # testutil/testdata_pulsar/testdata.pulsar.go # testutil/testdata_pulsar/tx.pulsar.go # testutil/testdata_pulsar/unknonwnproto.pulsar.go # types/tx/service.pb.go

…11248) * feat: include transactions in QueryBlockByHeight (#10880) ## Description Closes: #3729 - adds a new query to the tx service in Auth, which gets block information + decoded txs - added a new function to get the protoBlock from the node. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit dd65ef8) # Conflicts: # CHANGELOG.md # api/cosmos/group/v1beta1/types.pulsar.go # api/cosmos/tx/v1beta1/service.pulsar.go # api/cosmos/tx/v1beta1/service_grpc.pb.go # client/grpc/tmservice/block.go # testutil/testdata_pulsar/query.pulsar.go # testutil/testdata_pulsar/testdata.pulsar.go # testutil/testdata_pulsar/tx.pulsar.go # testutil/testdata_pulsar/unknonwnproto.pulsar.go # types/tx/service.pb.go * fix conflicts * remove pulsar Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

…) (cosmos#11248) * feat: include transactions in QueryBlockByHeight (cosmos#10880) ## Description Closes: cosmos#3729 - adds a new query to the tx service in Auth, which gets block information + decoded txs - added a new function to get the protoBlock from the node. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit dd65ef8) # Conflicts: # CHANGELOG.md # api/cosmos/group/v1beta1/types.pulsar.go # api/cosmos/tx/v1beta1/service.pulsar.go # api/cosmos/tx/v1beta1/service_grpc.pb.go # client/grpc/tmservice/block.go # testutil/testdata_pulsar/query.pulsar.go # testutil/testdata_pulsar/testdata.pulsar.go # testutil/testdata_pulsar/tx.pulsar.go # testutil/testdata_pulsar/unknonwnproto.pulsar.go # types/tx/service.pb.go * fix conflicts * remove pulsar Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

technicallyty requested review from aaronc and alexanderbez as code owners January 5, 2022 00:45

github-actions bot added C:CLI C:x/gov C:x/staking labels Jan 5, 2022

technicallyty commented Jan 5, 2022

View reviewed changes

x/gov/types/v1beta1/gov.pb.go Outdated Show resolved Hide resolved

github-actions bot removed C:x/gov C:x/staking labels Jan 5, 2022

technicallyty marked this pull request as draft January 5, 2022 08:31

alexanderbez reviewed Jan 5, 2022

View reviewed changes

client/grpc/tmservice/service.go Outdated Show resolved Hide resolved

github-actions bot added the C:x/auth label Jan 5, 2022

technicallyty commented Jan 5, 2022

View reviewed changes

amaury1093 reviewed Jan 6, 2022

View reviewed changes

proto/cosmos/base/tendermint/v1beta1/query.proto Outdated Show resolved Hide resolved

alexanderbez reviewed Jan 6, 2022

View reviewed changes

client/grpc/tmservice/service.go Outdated Show resolved Hide resolved

alexanderbez reviewed Jan 6, 2022

View reviewed changes

proto/cosmos/base/tendermint/v1beta1/query.proto Outdated Show resolved Hide resolved

technicallyty marked this pull request as ready for review January 6, 2022 18:44

fedekunze approved these changes Jan 10, 2022

View reviewed changes

fedekunze added the backport/0.45.x label Jan 10, 2022

amaury1093 self-assigned this Jan 10, 2022

amaury1093 reviewed Jan 11, 2022

View reviewed changes

feat: GetBlockWithTxs rpc

efcd78f

technicallyty force-pushed the ty/3729-tx_block branch from d3749f8 to efcd78f Compare February 16, 2022 20:54

github-actions bot removed the C:CLI label Feb 16, 2022

Merge branch 'master' into ty/3729-tx_block

5a1c3ba

technicallyty requested a review from amaury1093 February 16, 2022 21:08

amaury1093 approved these changes Feb 21, 2022

View reviewed changes

x/auth/tx/service.go Outdated Show resolved Hide resolved

amaury1093 reviewed Feb 21, 2022

View reviewed changes

proto/cosmos/tx/v1beta1/service.proto Show resolved Hide resolved

technicallyty and others added 2 commits February 21, 2022 10:24

Update proto/cosmos/tx/v1beta1/service.proto

f6219b0

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

feat: add pagination to query

a09d7f0

github-actions bot added the C:orm label Feb 22, 2022

Merge branch 'master' into ty/3729-tx_block

ad6110a

github-actions bot removed the C:orm label Feb 22, 2022

feat: add GetProtoBlock method

85738c2

github-actions bot added the C:CLI label Feb 22, 2022

tac0turtle approved these changes Feb 22, 2022

View reviewed changes

amaury1093 approved these changes Feb 22, 2022

View reviewed changes

x/auth/tx/service.go Outdated Show resolved Hide resolved

x/auth/tx/service.go Show resolved Hide resolved

proto/cosmos/tx/v1beta1/service.proto Show resolved Hide resolved

proto/cosmos/tx/v1beta1/service.proto Show resolved Hide resolved

technicallyty and others added 4 commits February 22, 2022 09:11

Update x/auth/tx/service.go

07c9ad8

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

Apply suggestions from code review

61b0fad

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

chore: use uint64

be95f40

Merge branch 'master' into ty/3729-tx_block

25e1c3e

technicallyty added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 22, 2022

mergify bot merged commit dd65ef8 into master Feb 22, 2022

mergify bot deleted the ty/3729-tx_block branch February 22, 2022 18:59

mergify bot mentioned this pull request Feb 22, 2022

feat: include transactions in QueryBlockByHeight (backport #10880) #11248

Merged

faddat mentioned this pull request Feb 28, 2022

v0.45.x akash-network/cosmos-sdk#176

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: include transactions in QueryBlockByHeight #10880

feat: include transactions in QueryBlockByHeight #10880

technicallyty commented Jan 5, 2022 •

edited

Loading

technicallyty Jan 5, 2022 •

edited

Loading

amaury1093 Jan 11, 2022 •

edited

Loading

alexanderbez Jan 11, 2022

technicallyty Jan 11, 2022 •

edited

Loading

technicallyty Jan 18, 2022

alexanderbez Jan 18, 2022

amaury1093 Jan 20, 2022

tac0turtle commented Feb 11, 2022

technicallyty commented Feb 16, 2022

amaury1093 commented Feb 16, 2022

codecov bot commented Feb 16, 2022 •

edited

Loading

technicallyty commented Feb 16, 2022

amaury1093 left a comment

technicallyty commented Feb 22, 2022

tac0turtle left a comment

amaury1093 left a comment •

edited

Loading

feat: include transactions in QueryBlockByHeight #10880

feat: include transactions in QueryBlockByHeight #10880

Conversation

technicallyty commented Jan 5, 2022 • edited Loading

Description

Author Checklist

Reviewers Checklist

technicallyty Jan 5, 2022 • edited Loading

Choose a reason for hiding this comment

amaury1093 Jan 11, 2022 • edited Loading

Choose a reason for hiding this comment

alexanderbez Jan 11, 2022

Choose a reason for hiding this comment

technicallyty Jan 11, 2022 • edited Loading

Choose a reason for hiding this comment

technicallyty Jan 18, 2022

Choose a reason for hiding this comment

alexanderbez Jan 18, 2022

Choose a reason for hiding this comment

amaury1093 Jan 20, 2022

Choose a reason for hiding this comment

tac0turtle commented Feb 11, 2022

technicallyty commented Feb 16, 2022

amaury1093 commented Feb 16, 2022

codecov bot commented Feb 16, 2022 • edited Loading

Codecov Report

technicallyty commented Feb 16, 2022

amaury1093 left a comment

Choose a reason for hiding this comment

technicallyty commented Feb 22, 2022

tac0turtle left a comment

Choose a reason for hiding this comment

amaury1093 left a comment • edited Loading

Choose a reason for hiding this comment

technicallyty commented Jan 5, 2022 •

edited

Loading

technicallyty Jan 5, 2022 •

edited

Loading

amaury1093 Jan 11, 2022 •

edited

Loading

technicallyty Jan 11, 2022 •

edited

Loading

codecov bot commented Feb 16, 2022 •

edited

Loading

amaury1093 left a comment •

edited

Loading