fix!: Charge gas for key length in gas meter #10247

likhita-809 · 2021-09-28T06:43:55Z

Description

Charge the per-byte fee for the key length as for the values in gas meter

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

…khita/charge-gas-for-key-length

codecov · 2021-09-29T05:54:11Z

Codecov Report

Merging #10247 (9b00df7) into master (f726a23) will decrease coverage by 0.00%.
The diff coverage is 61.29%.

❗ Current head 9b00df7 differs from pull request most recent head a5ae858. Consider uploading reports for the commit a5ae858 to get more accurate results

@@            Coverage Diff             @@
##           master   #10247      +/-   ##
==========================================
- Coverage   63.74%   63.73%   -0.01%     
==========================================
  Files         570      572       +2     
  Lines       53904    53966      +62     
==========================================
+ Hits        34359    34397      +38     
- Misses      17589    17612      +23     
- Partials     1956     1957       +1

Impacted Files	Coverage Δ
x/auth/migrations/legacytx/stdsign_aux.go	`0.00% <0.00%> (ø)`
x/auth/migrations/legacytx/stdtx_builder.go	`58.65% <0.00%> (-1.16%)`	⬇️
x/auth/tx/amino_aux.go	`88.00% <88.00%> (ø)`
store/gaskv/store.go	`100.00% <100.00%> (ø)`
x/auth/tx/builder.go	`78.40% <100.00%> (+0.51%)`	⬆️
x/auth/tx/mode_handler.go	`80.95% <100.00%> (+2.00%)`	⬆️
x/authz/client/testutil/tx.go	`98.14% <100.00%> (+<0.01%)`	⬆️

anilcse

Lgtm

ethanfrey

Thank you for responding to this so quickly 👍

Nice update. I only see one place more I would add this.

@alpe can you take a look as you brought up the original issue

store/gaskv/store.go

alpe

Thanks a lot for the quick PR. 💐

store/gaskv/store.go

…khita/charge-gas-for-key-length

amaury1093

lgtm, have a question about the flag's default value

client/flags/flags.go

CHANGELOG.md

…khita/charge-gas-for-key-length

alexanderbez

ACK pending fixing the tests (instead of bumping the default limit)

atheeshp

lgtm

amaury1093 · 2021-12-07T11:39:29Z

@Mergifyio backport release/v0.45.x

## Description Closes: #10243 Charge the per-byte fee for the key length as for the values in gas meter --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit dcf67d7) # Conflicts: # CHANGELOG.md # store/gaskv/store.go # store/gaskv/store_test.go

mergify · 2021-12-07T11:39:51Z

backport release/v0.45.x

✅ Backports have been created

#10697 fix!: Charge gas for key length in gas meter (backport #10247) has been created for branch release/v0.45.x

ethanfrey · 2021-12-07T16:49:53Z

Thanks @AmauryM

* fix!: Charge gas for key length in gas meter (#10247)  ## Description Closes: #10243 Charge the per-byte fee for the key length as for the values in gas meter --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit dcf67d7) # Conflicts: # CHANGELOG.md # store/gaskv/store.go # store/gaskv/store_test.go * Move to state machine breaking * revert deletion * Fix test Co-authored-by: likhita-809 <78951027+likhita-809@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>

…osmos#10697) * fix!: Charge gas for key length in gas meter (cosmos#10247)  ## Description Closes: cosmos#10243 Charge the per-byte fee for the key length as for the values in gas meter --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit dcf67d7) # Conflicts: # CHANGELOG.md # store/gaskv/store.go # store/gaskv/store_test.go * Move to state machine breaking * revert deletion * Fix test Co-authored-by: likhita-809 <78951027+likhita-809@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>

…osmos#10697) * fix!: Charge gas for key length in gas meter (cosmos#10247)  Closes: cosmos#10243 Charge the per-byte fee for the key length as for the values in gas meter --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit dcf67d7) * Move to state machine breaking * revert deletion * Fix test Co-authored-by: likhita-809 <78951027+likhita-809@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>

…osmos#10697) * fix!: Charge gas for key length in gas meter (cosmos#10247)  ## Description Closes: cosmos#10243 Charge the per-byte fee for the key length as for the values in gas meter --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit dcf67d7) # Conflicts: # CHANGELOG.md # store/gaskv/store.go # store/gaskv/store_test.go * Move to state machine breaking * revert deletion * Fix test Co-authored-by: likhita-809 <78951027+likhita-809@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>

likhita-809 added 2 commits September 28, 2021 12:10

charge gas for key length

deccdfa

fix tests

d2e1e13

likhita-809 changed the title ~~feat: Charge gas for key length in gas meter~~ fix: Charge gas for key length in gas meter Sep 28, 2021

likhita-809 added 2 commits September 28, 2021 12:20

add changelog

aafdd93

fix failing tests

eb38cd8

github-actions bot added the C:x/auth label Sep 28, 2021

likhita-809 added 3 commits September 28, 2021 18:25

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…

7842701

…khita/charge-gas-for-key-length

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…

7e36ff3

…khita/charge-gas-for-key-length

fix failing tests

f7d4d9a

github-actions bot removed the C:x/auth label Sep 29, 2021

likhita-809 marked this pull request as ready for review September 29, 2021 06:01

likhita-809 requested review from aaronc and alexanderbez as code owners September 29, 2021 06:01

likhita-809 requested review from amaury1093, aleem1314, anilcse, atheeshp, blushi and ethanfrey September 29, 2021 06:02

anilcse approved these changes Sep 29, 2021

View reviewed changes

ethanfrey reviewed Sep 29, 2021

View reviewed changes

store/gaskv/store.go Show resolved Hide resolved

charge gas for key length in Get func

32b294d

alpe reviewed Sep 29, 2021

View reviewed changes

store/gaskv/store.go Show resolved Hide resolved

likhita-809 added 5 commits September 29, 2021 14:28

fix tests

bb8ce7b

fix failed tests

71225ee

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…

4306095

…khita/charge-gas-for-key-length

try fix failing tests

33c7863

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…

63ae5c1

…khita/charge-gas-for-key-length

github-actions bot added the C:CLI label Sep 29, 2021

likhita-809 requested a review from alpe September 30, 2021 04:42

likhita-809 added 2 commits September 30, 2021 14:11

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…

6858672

…khita/charge-gas-for-key-length

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…

7caa51f

…khita/charge-gas-for-key-length

amaury1093 approved these changes Sep 30, 2021

View reviewed changes

client/flags/flags.go Outdated Show resolved Hide resolved

amaury1093 changed the title ~~fix: Charge gas for key length in gas meter~~ fix!: Charge gas for key length in gas meter Sep 30, 2021

amaury1093 reviewed Sep 30, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

likhita-809 added 2 commits September 30, 2021 20:07

fix changelog

f7ac177

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…

435a71c

…khita/charge-gas-for-key-length

alexanderbez approved these changes Sep 30, 2021

View reviewed changes

add gas-limit flag manually

bda5834

github-actions bot added the C:x/authz label Oct 1, 2021

atheeshp approved these changes Oct 1, 2021

View reviewed changes

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 4, 2021

amaury1093 and others added 3 commits October 4, 2021 12:47

Merge branch 'master' into likhita/charge-gas-for-key-length

6ed2c46

Merge branch 'master' into likhita/charge-gas-for-key-length

9b00df7

Merge branch 'master' into likhita/charge-gas-for-key-length

a5ae858

mergify bot merged commit dcf67d7 into master Oct 4, 2021

mergify bot deleted the likhita/charge-gas-for-key-length branch October 4, 2021 11:46

mergify bot mentioned this pull request Dec 7, 2021

fix!: Charge gas for key length in gas meter (backport #10247) #10697

Merged

faddat mentioned this pull request Feb 28, 2022

v0.45.x akash-network/cosmos-sdk#176

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix!: Charge gas for key length in gas meter #10247

fix!: Charge gas for key length in gas meter #10247

likhita-809 commented Sep 28, 2021

codecov bot commented Sep 29, 2021 •

edited

Loading

anilcse left a comment

ethanfrey left a comment •

edited

Loading

alpe left a comment

amaury1093 left a comment

alexanderbez left a comment

atheeshp left a comment

amaury1093 commented Dec 7, 2021

mergify bot commented Dec 7, 2021

ethanfrey commented Dec 7, 2021

fix!: Charge gas for key length in gas meter #10247

fix!: Charge gas for key length in gas meter #10247

Conversation

likhita-809 commented Sep 28, 2021

Description

Author Checklist

Reviewers Checklist

codecov bot commented Sep 29, 2021 • edited Loading

Codecov Report

anilcse left a comment

Choose a reason for hiding this comment

ethanfrey left a comment • edited Loading

Choose a reason for hiding this comment

alpe left a comment

Choose a reason for hiding this comment

amaury1093 left a comment

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment

atheeshp left a comment

Choose a reason for hiding this comment

amaury1093 commented Dec 7, 2021

mergify bot commented Dec 7, 2021

✅ Backports have been created

ethanfrey commented Dec 7, 2021

codecov bot commented Sep 29, 2021 •

edited

Loading

ethanfrey left a comment •

edited

Loading