-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: 10180 Fix SDK #10237
docs: 10180 Fix SDK #10237
Conversation
oops @brennhill to make these types of changes more manageable, I had limited the scope in #10180
and had staged the issue to be used in October Codefest but am so so happy to see contributors jump in to make improvements no matter when they do the work! can you take a look @aaronc and @alexanderbez ? please and thank you |
@brennhill did you want to close this PR and then open a different PR in the month of October, and please limit your scope |
@barriebryon I could do that but I don't need to wait until october. If the changes are good I'd rather you go ahead and use them. It frees up my mind for other things. |
@brennhill thanks for being willing to make these improvements! Sounds good to me, and I look forward to your continued contributions. Grab an issue during October if you want to participate in October Codefest. Any fixes for the codebase are good fixes and we appreciate you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so many good changes, thank you @brennhill can you check your "an" and make changes as required ?
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much for helping with our consistent branding, @brennhill!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, do we want to always put Cosmos next to SDK, even when we say "the SDK"?
yes @robert-zaremba we do! Branding, especially in docs, is essential. Using the full "Cosmos SDK" is essential. For example, when a bit of a doc gets shared in the world at large, we want to make sure our reader knows "the SDK" is "the Cosmos SDK" Thanks for asking! |
Description
Closes: #10180 #10180
Fixes how we refer to the SDK throughout the documentation.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change