Skip to content

version: set sdk version in node_info #9420

Closed
@tac0turtle

Description

Summary

When looking at explorer or building a multichain explorer it would be nice to see what version of the sdk the chain is using.

The number shown will mainly represent the major releases and possibly the patch releases. For example on the hub it would display cosmos_sdk_version: 0.42.x

Proposal

add cosmos_sdk_version to Version_info

// VersionInfo is the type for the GetNodeInfoResponse message.
message VersionInfo {
  string          name       = 1;
  string          app_name   = 2;
  string          version    = 3;
  string          git_commit = 4;
  string          build_tags = 5;
  string          go_version = 6;
  repeated Module build_deps = 7;
++ string cosmos_sdk_version = 8;
}

This value would be set through a global or local to a file, string.

Update release procedure to bump the version tag on releases. This is similar to how we do version handling in Tendermint.

The reason this approach is being proposed is, many developers forget to set the ldflag, adding an extra step in our process of doing releases will pay large dividends instead of messaging teams to add the version as an ldflag.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

C: gRPCIssues and PRs related to the gRPC service and HTTP gateway.S:proposal acceptedT: Client UXT: Dev UXUX for SDK developers (i.e. how to call our code)

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions