Add a name to crisis invariants, and print these in logs #8621
Closed
Description
opened on Feb 18, 2021
Summary
Currently crisis invariant checks look like:
7:47AM INF asserting crisis invariants inv=0/11 module=x/crisis
7:47AM INF asserting crisis invariants inv=1/11 module=x/crisis
7:47AM INF asserting crisis invariants inv=2/11 module=x/crisis
7:47AM INF asserting crisis invariants inv=3/11 module=x/crisis
7:47AM INF asserting crisis invariants inv=4/11 module=x/crisis
It would be nice if there could also be a human friendly name printed out for what the invariant being checked is.
Problem Definition
Improves understandability of logs, and helps node operators learn what the invariants being checked are.
Proposal
Use the existing name field associated with every invariant, and print them in the crisis invariant log line as:
7:47AM INF asserting crisis invariants inv=2/11 name=$INVARIANT_NAME module=x/crisis
For Admin Use
- Not duplicate issue
- Appropriate labels applied
- Appropriate contributors tagged
- Contributor assigned/self-assigned
Activity