Can't query multisig account

[yun-yeo]

Summary of Bug

Current account querier return MarshalJSON(Account) when it receive account query. A cli program, which request the account info, do UnmarshalJSON like Here. In this process, the cli program return error because multisig pubkey is longer than the length what bech32 decoder allow.

so the response is ERROR: decoding bech32 failed: invalid bech32 string length 217

ref) bech.Decode func

// Decode decodes a bech32 encoded string, returning the human-readable
// part and the data part excluding the checksum.
func Decode(bech string) (string, []byte, error) {
	// The maximum allowed length for a bech32 string is 90. It must also
	// be at least 8 characters, since it needs a non-empty HRP, a
	// separator, and a 6 character checksum.
	if len(bech) < 8 || len(bech) > 90 {
		return "", nil, fmt.Errorf("invalid bech32 string length %d",
			len(bech))
	}
...

Version

v0.38.x

Steps to Reproduce

1. Create multisig address by send some amount of funds
2. Send tx from the multisig address.
3. Query multisig address

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[yun-yeo]

Seems this is due to

cosmos-sdk/x/auth/types/account.go

Line 182 in 5f6e499

pks, err := sdk.Bech32ifyPubKey(sdk.Bech32PubKeyTypeAccPub, acc.PubKey)

I don't know why we need pretty function at custom MarshalJSON(). The actual Account is response returned from String() which is calling MarshalYAML().

[webmaster128]

It is not a problem of the decoder. The bech32 spec has a hard length limit of 90 characters. I.e. such long data should never be stored as bech32 in the first place.

[alexanderbez]

@YunSuk-Yeo custom JSON Marshaling does not exist for the BaseAccount anymore (i.e. on master). If anything, we need to backport this to 0.38/0.39, but it's technically a breaking API change.

[alexanderbez]

I'm going to close this issue and defer to @alessio on how to treat 0.38/0.39.

[alexanderbez]

Fix on 0.39: #6749

[yun-yeo]

Thanks for launch pad update!