Proposal tally not increasing after voting

[fedekunze]

Summary of Bug

The proposal Tally Result is not increasing after submitting a vote.

Ref: luniehq/lunie#1591

Steps to Reproduce

Added a test case on lcd_test.go and failed.

We are not increasing the proposal tally after voting:

cosmos-sdk/x/gov/keeper.go

Lines 288 to 309 in 6e813ab

	func (keeper Keeper) AddVote(ctx sdk.Context, proposalID uint64, voterAddr sdk.AccAddress, option VoteOption) sdk.Error {
	proposal := keeper.GetProposal(ctx, proposalID)
	if proposal == nil {
	return ErrUnknownProposal(keeper.codespace, proposalID)
	}
	if proposal.GetStatus() != StatusVotingPeriod {
	return ErrInactiveProposal(keeper.codespace, proposalID)
	}
	if !validVoteOption(option) {
	return ErrInvalidVote(keeper.codespace, option)
	}
	vote := Vote{
	ProposalID: proposalID,
	Voter: voterAddr,
	Option: option,
	}
	keeper.setVote(ctx, proposalID, voterAddr, vote)
	return nil
	}

Actionable Item(s):

• Rename the field tally_result => final_tally_result

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[sunnya97]

That's not what TallyResult is for! It's the result of the vote and takes into account the staked weights of the voter. The TallyResult in state is only filled in once the voting is finished. If the proposal is still in the VotingPeriod, using the Tally querier endpoint, it doesn't read from state, but rather runs a tally at the current time, based on current stake weights (the stake weight may change by the time the real tally is run.

[fedekunze]

I'll reopen this bc I still think it needs further discussion. Maybe we can implement a workaround without rallying on the tally endpoint.

cc: @jackzampolin @johnmcdowall @alexanderbez @faboweb

[jackzampolin]

think it needs further discussion can you elaborate?

[fedekunze]

So right now if the proposal is on voting period the only way to get the current tally is using the /tally endpoint. We can get rid of that endpoint by returning a proposal with an updated tally_result from the tally querier if the proposal is on voting period:

if proposal.ProposalStatus == VotingPeriod {
   proposal.TallyResult = tallyQuerier()
}

[alexanderbez]

I agree in that I think it'll be a better UX if it's directly updated in the proposal. When I was playing around with proposals, I'd vote and query the proposal directly after and saw no updates to the tally...I thought that to be strange and it's not directly obvious to me that there is a tally endpoint/command.