Skip to content

Makefile stabilization and updates #2672

Closed
@greg-szabo

Description

Summary

  • Make the Makefile compile for Windows (required for SRE OKR binary signing)
  • Keep the current feature set intact, but improve on how it executes

Problem Definition

The current Makefile's ledger_check target executes even when the target is not called. Along with similar discrepancies, the Makefile does not run on Windows. It has to, if we want to build Voyager with gaiad for Windows, which is a launch requirement.

Proposal

  • Fix the check_ledger target to make it run only when it's called.
  • Fix the get_tools target to be compatible with Windows.
  • Fix the build target on Windows: Version information is lost, gaiad.exe version returns an empty string.
  • Make update_gaia_lite_docs optional for the build target. (don't run update_gaia_lite_docs on build #2647)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions