Skip to content

Distribution: validator dist info FeePoolWithdrawalHeight was not updated #2618

Closed

Description

Caught by #2617 (multi-seed simulation ranges over random genesis parameter combinations).

Replicable with

go test ./cmd/gaia/app -run TestFullGaiaSimulation -SimulationEnabled=true -SimulationNumBlocks=400 -SimulationBlockSize=200 -SimulationCommit=true -SimulationSeed=124 -v -timeout 24h

on 3884b13

Fails on block 5 with:

Simulating... block 5/400, operation 0/0. Panic with err 
 expected validator dist info FeePoolWithdrawalHeight to be updated, but was not. 
goroutine 52 [running]:
runtime/debug.Stack(0xc001723a20, 0x2, 0x2) 
  /usr/lib/go/src/runtime/debug/stack.go:24 +0xa7
github.com/cosmos/cosmos-sdk/x/mock/simulation.SimulateFromSeed.func3(0xc000914f80, 0xc0000e4fc0, 0xc000b54380)
  /home/cwgoes/working/go/src/github.com/cosmos/cosmos-sdk/x/mock/simulation/random_simulate_blocks.go:121 +0xb6
panic(0xd5b9e0, 0x1104b80)
  /usr/lib/go/src/runtime/panic.go:513 +0x1b9
github.com/cosmos/cosmos-sdk/x/distribution/keeper.Keeper.onValidatorPowerDidChange(0x110b280, 0xc000b54100, 0xc00021f570, 0xc00021f570, 0x110b280, 0xc000b54150, 0x110b2c0, 0xc000b54160, 0xc000804d60, 0x5, ...) 
  /home/cwgoes/working/go/src/github.com/cosmos/cosmos-sdk/x/distribution/keeper/hooks.go:45 +0x169
github.com/cosmos/cosmos-sdk/x/distribution/keeper.Hooks.OnValidatorPowerDidChange(0x110b280, 0xc000b54100, 0xc00021f570, 0xc00021f570, 0x110b280, 0xc000b54150, 0x110b2c0, 0xc000b54160, 0xc000804d60, 0x5, ...) 
  /home/cwgoes/working/go/src/github.com/cosmos/cosmos-sdk/x/distribution/keeper/hooks.go:124 +0xd0
github.com/cosmos/cosmos-sdk/cmd/gaia/app.Hooks.OnValidatorPowerDidChange(0x110b280, 0xc000b54100, 0xc00021f570, 0xc00021f570, 0x110b280, 0xc000b54150, 0x110b2c0, 0xc000b54160, 0xc000804d60, 0x5, ...) 
  /home/cwgoes/working/go/src/github.com/cosmos/cosmos-sdk/cmd/gaia/app/app.go:349 +0x100

Fails on several other seeds with similar error messages.

cc @rigelrozanski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions