Skip to content

AccountMapper.IterateAccounts may leak resource #2105

Closed

Description

Summary of Bug

AccountMapper.IterateAccounts may leak resource.

Steps to Reproduce

iter := sdk.KVStorePrefixIterator(store, []byte("account:"))

Iterator need to Close after use,this may leak a go routine for iavlIterator.

almost all of Iterator implement is trival,but iavlIterator.Close is no-trival.
see

close(iter.quitCh)

in democoin/oracle/handle.go also has a similar case,but it's a full iterator,here only cause confusion,not incorrect.

iter := sdk.KVStorePrefixIterator(store, prefix)

This Issue is base on tag v0.24.0


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions