Skip to content

Commit d40677a

Browse files
authored
chore: make telemetry consistent (#20025)
1 parent 4ad0821 commit d40677a

File tree

4 files changed

+2
-8
lines changed

4 files changed

+2
-8
lines changed

baseapp/abci.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ func (app *BaseApp) Query(_ context.Context, req *abci.RequestQuery) (resp *abci
177177

178178
telemetry.IncrCounter(1, "query", "count")
179179
telemetry.IncrCounter(1, "query", req.Path)
180-
defer telemetry.MeasureSince(time.Now(), req.Path)
180+
defer telemetry.MeasureSince(telemetry.Now(), req.Path)
181181

182182
if req.Path == QueryPathBroadcastTx {
183183
return sdkerrors.QueryResult(errorsmod.Wrap(sdkerrors.ErrInvalidRequest, "can't route a broadcast tx message"), app.trace), nil

x/circuit/module.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import (
1515

1616
"github.com/cosmos/cosmos-sdk/client"
1717
"github.com/cosmos/cosmos-sdk/codec"
18-
"github.com/cosmos/cosmos-sdk/telemetry"
1918
"github.com/cosmos/cosmos-sdk/types/module"
2019
)
2120

@@ -92,12 +91,10 @@ func (am AppModule) ValidateGenesis(bz json.RawMessage) error {
9291

9392
// InitGenesis performs genesis initialization for the circuit module.
9493
func (am AppModule) InitGenesis(ctx context.Context, data json.RawMessage) error {
95-
start := telemetry.Now()
9694
var genesisState types.GenesisState
9795
if err := am.cdc.UnmarshalJSON(data, &genesisState); err != nil {
9896
return err
9997
}
100-
telemetry.MeasureSince(start, "InitGenesis", "crisis", "unmarshal")
10198

10299
return am.keeper.InitGenesis(ctx, &genesisState)
103100
}

x/crisis/module.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
"cosmossdk.io/core/registry"
1313

1414
"github.com/cosmos/cosmos-sdk/codec"
15-
"github.com/cosmos/cosmos-sdk/telemetry"
1615
"github.com/cosmos/cosmos-sdk/types/module"
1716
"github.com/cosmos/cosmos-sdk/x/crisis/keeper"
1817
"github.com/cosmos/cosmos-sdk/x/crisis/types"
@@ -121,7 +120,6 @@ func (am AppModule) InitGenesis(ctx context.Context, data json.RawMessage) error
121120
if err := am.cdc.UnmarshalJSON(data, &genesisState); err != nil {
122121
return err
123122
}
124-
telemetry.MeasureSince(telemetry.Now(), "InitGenesis", "crisis", "unmarshal")
125123

126124
am.keeper.InitGenesis(ctx, &genesisState)
127125
if !am.skipGenesisInvariants {

x/epochs/keeper/abci.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package keeper
33
import (
44
"context"
55
"fmt"
6-
"time"
76

87
"cosmossdk.io/x/epochs/types"
98

@@ -12,7 +11,7 @@ import (
1211

1312
// BeginBlocker of epochs module.
1413
func (k Keeper) BeginBlocker(ctx context.Context) error {
15-
defer telemetry.ModuleMeasureSince(types.ModuleName, time.Now(), telemetry.MetricKeyBeginBlocker)
14+
defer telemetry.ModuleMeasureSince(types.ModuleName, telemetry.Now(), telemetry.MetricKeyBeginBlocker)
1615

1716
logger := k.Logger()
1817
headerInfo := k.environment.HeaderService.GetHeaderInfo(ctx)

0 commit comments

Comments
 (0)