Skip to content

Commit b0c3c75

Browse files
julienrbrtmergify[bot]
authored andcommitted
refactor(simapp): simplify simapp di (#21718)
(cherry picked from commit 7ee7c20) # Conflicts: # simapp/v2/app_di.go
1 parent 71803b7 commit b0c3c75

File tree

2 files changed

+13
-54
lines changed

2 files changed

+13
-54
lines changed

simapp/app_di.go

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,12 @@ import (
1515
"cosmossdk.io/depinject"
1616
"cosmossdk.io/log"
1717
"cosmossdk.io/x/accounts"
18-
authzkeeper "cosmossdk.io/x/authz/keeper"
1918
bankkeeper "cosmossdk.io/x/bank/keeper"
2019
circuitkeeper "cosmossdk.io/x/circuit/keeper"
2120
consensuskeeper "cosmossdk.io/x/consensus/keeper"
2221
distrkeeper "cosmossdk.io/x/distribution/keeper"
23-
epochskeeper "cosmossdk.io/x/epochs/keeper"
24-
evidencekeeper "cosmossdk.io/x/evidence/keeper"
2522
feegrantkeeper "cosmossdk.io/x/feegrant/keeper"
26-
govkeeper "cosmossdk.io/x/gov/keeper"
27-
groupkeeper "cosmossdk.io/x/group/keeper"
28-
mintkeeper "cosmossdk.io/x/mint/keeper"
29-
nftkeeper "cosmossdk.io/x/nft/keeper"
3023
_ "cosmossdk.io/x/protocolpool"
31-
poolkeeper "cosmossdk.io/x/protocolpool/keeper"
3224
slashingkeeper "cosmossdk.io/x/slashing/keeper"
3325
stakingkeeper "cosmossdk.io/x/staking/keeper"
3426
upgradekeeper "cosmossdk.io/x/upgrade/keeper"
@@ -70,25 +62,18 @@ type SimApp struct {
7062
txConfig client.TxConfig
7163
interfaceRegistry codectypes.InterfaceRegistry
7264

73-
// keepers
65+
// required keepers during wiring
66+
// others keepers are all in the app
7467
AccountsKeeper accounts.Keeper
7568
AuthKeeper authkeeper.AccountKeeper
7669
BankKeeper bankkeeper.Keeper
7770
StakingKeeper *stakingkeeper.Keeper
7871
SlashingKeeper slashingkeeper.Keeper
79-
MintKeeper mintkeeper.Keeper
8072
DistrKeeper distrkeeper.Keeper
81-
GovKeeper *govkeeper.Keeper
8273
UpgradeKeeper *upgradekeeper.Keeper
83-
AuthzKeeper authzkeeper.Keeper
84-
EvidenceKeeper evidencekeeper.Keeper
8574
FeeGrantKeeper feegrantkeeper.Keeper
86-
GroupKeeper groupkeeper.Keeper
87-
NFTKeeper nftkeeper.Keeper
8875
ConsensusParamsKeeper consensuskeeper.Keeper
8976
CircuitBreakerKeeper circuitkeeper.Keeper
90-
PoolKeeper poolkeeper.Keeper
91-
EpochsKeeper *epochskeeper.Keeper
9277

9378
// simulation manager
9479
sm *module.SimulationManager
@@ -187,19 +172,11 @@ func NewSimApp(
187172
&app.BankKeeper,
188173
&app.StakingKeeper,
189174
&app.SlashingKeeper,
190-
&app.MintKeeper,
191175
&app.DistrKeeper,
192-
&app.GovKeeper,
193176
&app.UpgradeKeeper,
194-
&app.AuthzKeeper,
195-
&app.EvidenceKeeper,
196177
&app.FeeGrantKeeper,
197-
&app.GroupKeeper,
198-
&app.NFTKeeper,
199178
&app.ConsensusParamsKeeper,
200179
&app.CircuitBreakerKeeper,
201-
&app.PoolKeeper,
202-
&app.EpochsKeeper,
203180
); err != nil {
204181
panic(err)
205182
}

simapp/v2/app_di.go

Lines changed: 11 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -13,30 +13,20 @@ import (
1313
"cosmossdk.io/log"
1414
"cosmossdk.io/runtime/v2"
1515
"cosmossdk.io/store/v2/root"
16+
<<<<<<< HEAD
1617
"cosmossdk.io/x/accounts"
1718
authzkeeper "cosmossdk.io/x/authz/keeper"
1819
bankkeeper "cosmossdk.io/x/bank/keeper"
1920
circuitkeeper "cosmossdk.io/x/circuit/keeper"
21+
=======
22+
>>>>>>> 7ee7c207d (refactor(simapp): simplify simapp di (#21718))
2023
consensuskeeper "cosmossdk.io/x/consensus/keeper"
21-
distrkeeper "cosmossdk.io/x/distribution/keeper"
22-
epochskeeper "cosmossdk.io/x/epochs/keeper"
23-
evidencekeeper "cosmossdk.io/x/evidence/keeper"
24-
feegrantkeeper "cosmossdk.io/x/feegrant/keeper"
25-
govkeeper "cosmossdk.io/x/gov/keeper"
26-
groupkeeper "cosmossdk.io/x/group/keeper"
27-
mintkeeper "cosmossdk.io/x/mint/keeper"
28-
nftkeeper "cosmossdk.io/x/nft/keeper"
29-
_ "cosmossdk.io/x/protocolpool"
30-
poolkeeper "cosmossdk.io/x/protocolpool/keeper"
31-
slashingkeeper "cosmossdk.io/x/slashing/keeper"
32-
stakingkeeper "cosmossdk.io/x/staking/keeper"
3324
upgradekeeper "cosmossdk.io/x/upgrade/keeper"
3425

3526
"github.com/cosmos/cosmos-sdk/client"
3627
"github.com/cosmos/cosmos-sdk/codec"
3728
codectypes "github.com/cosmos/cosmos-sdk/codec/types"
3829
"github.com/cosmos/cosmos-sdk/std"
39-
authkeeper "github.com/cosmos/cosmos-sdk/x/auth/keeper"
4030
_ "github.com/cosmos/cosmos-sdk/x/genutil"
4131
)
4232

@@ -53,6 +43,7 @@ type SimApp[T transaction.Tx] struct {
5343
txConfig client.TxConfig
5444
interfaceRegistry codectypes.InterfaceRegistry
5545

46+
<<<<<<< HEAD
5647
// keepers
5748
AccountsKeeper accounts.Keeper
5849
AuthKeeper authkeeper.AccountKeeper
@@ -62,16 +53,12 @@ type SimApp[T transaction.Tx] struct {
6253
MintKeeper mintkeeper.Keeper
6354
DistrKeeper distrkeeper.Keeper
6455
GovKeeper *govkeeper.Keeper
56+
=======
57+
// required keepers during wiring
58+
// others keepers are all in the app
59+
>>>>>>> 7ee7c207d (refactor(simapp): simplify simapp di (#21718))
6560
UpgradeKeeper *upgradekeeper.Keeper
66-
AuthzKeeper authzkeeper.Keeper
67-
EvidenceKeeper evidencekeeper.Keeper
68-
FeeGrantKeeper feegrantkeeper.Keeper
69-
GroupKeeper groupkeeper.Keeper
70-
NFTKeeper nftkeeper.Keeper
7161
ConsensusParamsKeeper consensuskeeper.Keeper
72-
CircuitBreakerKeeper circuitkeeper.Keeper
73-
PoolKeeper poolkeeper.Keeper
74-
EpochsKeeper *epochskeeper.Keeper
7562
}
7663

7764
func init() {
@@ -166,23 +153,18 @@ func NewSimApp[T transaction.Tx](
166153
&app.legacyAmino,
167154
&app.txConfig,
168155
&app.interfaceRegistry,
156+
<<<<<<< HEAD
169157
&app.AuthKeeper,
170158
&app.BankKeeper,
171159
&app.StakingKeeper,
172160
&app.SlashingKeeper,
173161
&app.MintKeeper,
174162
&app.DistrKeeper,
175163
&app.GovKeeper,
164+
=======
165+
>>>>>>> 7ee7c207d (refactor(simapp): simplify simapp di (#21718))
176166
&app.UpgradeKeeper,
177-
&app.AuthzKeeper,
178-
&app.EvidenceKeeper,
179-
&app.FeeGrantKeeper,
180-
&app.GroupKeeper,
181-
&app.NFTKeeper,
182167
&app.ConsensusParamsKeeper,
183-
&app.CircuitBreakerKeeper,
184-
&app.PoolKeeper,
185-
&app.EpochsKeeper,
186168
); err != nil {
187169
panic(err)
188170
}

0 commit comments

Comments
 (0)