Merge branch 'main' into store/factory_migration

Author: Alex | Interchain Labs

.github/.codespellignore

@@ -2,8 +2,10 @@ cips
 pullrequest
 keypair
 pastTime
-hasTables
 Nam
 EyT
 upTo
-pullRequests
+pullRequests
+AccountAt
+expRes
+hasTables

CHANGELOG.md

@@ -53,6 +53,7 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i
 ### Bug Fixes
 
 * (query) [23002](https://github.com/cosmos/cosmos-sdk/pull/23002) Fix collection filtered pagination.
+* (x/auth/tx) [#23170](https://github.com/cosmos/cosmos-sdk/pull/23170) Avoid panic from newWrapperFromDecodedTx when AuthInfo.Fee is optional in decodedTx.
 * (x/auth/tx) [23144](https://github.com/cosmos/cosmos-sdk/pull/23144) Add missing CacheWithValue for ExtensionOptions.
 * (x/auth/tx) [#23148](https://github.com/cosmos/cosmos-sdk/pull/23148) Avoid panic from intoAnyV2 when v1.PublicKey is optional.
 

CODE_OF_CONDUCT.md

@@ -2,7 +2,7 @@
 
 ## Our Pledge
 
-In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, religion, or sexual identity and orientation.
+In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, education, socioeconomic status, nationality, personal appearance, race, religion, or sexual identity and orientation.
 
 ## Our Standards
 

api/go.mod

@@ -14,7 +14,7 @@ require (
 require (
 	buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go v1.36.1-20240130113600-88ef6483f90f.1 // indirect
 	github.com/google/go-cmp v0.6.0 // indirect
-	golang.org/x/net v0.32.0 // indirect
+	golang.org/x/net v0.33.0 // indirect
 	golang.org/x/sys v0.28.0 // indirect
 	golang.org/x/text v0.21.0 // indirect
 	google.golang.org/genproto/googleapis/rpc v0.0.0-20241202173237-19429a94021a // indirect

api/go.sum

@@ -10,8 +10,8 @@ github.com/golang/protobuf v1.5.4 h1:i7eJL8qZTpSEXOPTxNKhASYpMn+8e5Q6AdndVa1dWek
 github.com/golang/protobuf v1.5.4/go.mod h1:lnTiLA8Wa4RWRcIUkrtSVa5nRhsEGBg48fD6rSs7xps=
 github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
 github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
-golang.org/x/net v0.32.0 h1:ZqPmj8Kzc+Y6e0+skZsuACbx+wzMgo5MQsJh9Qd6aYI=
-golang.org/x/net v0.32.0/go.mod h1:CwU0IoeOlnQQWJ6ioyFrfRuomB8GKF6KbYXZVyeXNfs=
+golang.org/x/net v0.33.0 h1:74SYHlV8BIgHIFC/LrYkOGIwL19eTYXQ5wc6TBuO36I=
+golang.org/x/net v0.33.0/go.mod h1:HXLR5J+9DxmrqMwG9qjGCxZ+zKXxBru04zlTvWlWuN4=
 golang.org/x/sys v0.28.0 h1:Fksou7UEQUWlKvIdsqzJmUmCX3cZuD2+P3XyyzwMhlA=
 golang.org/x/sys v0.28.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
 golang.org/x/text v0.21.0 h1:zyQAAkrwaneQ066sspRyJaG9VNi/YJ1NfzcGB3hZ/qo=

client/config/toml.go

@@ -73,7 +73,7 @@ func writeConfigFile(configFilePath string, config interface{}) error {
 	return os.WriteFile(configFilePath, buffer.Bytes(), 0o600)
 }
 
-// getClientConfig reads values from client.toml file and unmarshalls them into ClientConfig
+// getClientConfig reads values from client.toml file and unmarshals them into ClientConfig
 func getClientConfig(configPath string, v *viper.Viper) (*Config, error) {
 	v.AddConfigPath(configPath)
 	v.SetConfigName("client")

client/v2/CHANGELOG.md

@@ -36,6 +36,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ## [Unreleased]
 
+* [#23325](https://github.com/cosmos/cosmos-sdk/pull/23325) Remove `NewAppOptionsFromConfig` that isn't needed in normal wiring.
+
 ## [v2.10.0-beta.1](https://github.com/cosmos/cosmos-sdk/releases/tag/client/v2/v2.10.0-beta.1) - 2024-12-18
 
 ### Features

client/v2/README.md

@@ -304,7 +304,7 @@ To sign a file `sign-file` command offers some helpful flags:
       --encoding string          Choose an encoding method for the file content to be added as msg data (no-encoding|base64|hex) (default "no-encoding")
       --indent string            Choose an indent for the tx (default "  ")
       --notEmitUnpopulated       Don't show unpopulated fields in the tx
-      --output string            Choose an output format for the tx (json|text (default "json")
+      --output string            Choose an output format for the tx (json|text) (default "json")
       --output-document string   The document will be written to the given file instead of STDOUT
 ```
 

client/v2/autocli/app.go

@@ -1,7 +1,6 @@
 package autocli
 
 import (
-	"github.com/cosmos/gogoproto/proto"
 	"github.com/spf13/cobra"
 	"google.golang.org/protobuf/reflect/protoregistry"
 
@@ -10,12 +9,9 @@ import (
 	"cosmossdk.io/core/address"
 	"cosmossdk.io/core/appmodule"
 	"cosmossdk.io/depinject"
-	"cosmossdk.io/log"
-	"cosmossdk.io/x/tx/signing"
 
 	sdkflags "github.com/cosmos/cosmos-sdk/client/flags"
 	"github.com/cosmos/cosmos-sdk/codec"
-	"github.com/cosmos/cosmos-sdk/codec/types"
 	authtx "github.com/cosmos/cosmos-sdk/x/auth/tx"
 )
 
@@ -143,49 +139,3 @@ func (appOptions AppOptions) EnhanceRootCommandWithBuilder(rootCmd *cobra.Comman
 
 	return nil
 }
-
-// NewAppOptionsFromConfig returns AppOptions for an app based on the provided modulesConfig and moduleOptions.
-// It returns an AppOptions instance usable for CLI parsing but not execution. For an execution usable AppOptions
-// see ProvideAppOptions, which expects input to be filled by depinject.
-func NewAppOptionsFromConfig(
-	modulesConfig depinject.Config,
-	moduleOptions map[string]*autocliv1.ModuleOptions,
-) (AppOptions, error) {
-	interfaceRegistry, err := types.NewInterfaceRegistryWithOptions(types.InterfaceRegistryOptions{
-		ProtoFiles: proto.HybridResolver,
-		SigningOptions: signing.Options{
-			AddressCodec:          nopAddressCodec{},
-			ValidatorAddressCodec: nopAddressCodec{},
-		},
-	})
-	if err != nil {
-		return AppOptions{}, err
-	}
-	cfg := struct {
-		depinject.In
-		Modules map[string]appmodule.AppModule
-	}{
-		Modules: nil,
-	}
-	err = depinject.Inject(depinject.Configs(
-		modulesConfig,
-		depinject.Supply(
-			log.NewNopLogger(),
-		)), &cfg)
-	if err != nil {
-		return AppOptions{}, err
-	}
-
-	return AppOptions{
-		Modules:        cfg.Modules,
-		ModuleOptions:  moduleOptions,
-		skipValidation: true,
-		Cdc:            codec.NewProtoCodec(interfaceRegistry),
-	}, nil
-}
-
-type nopAddressCodec struct{}
-
-func (nopAddressCodec) StringToBytes(_ string) ([]byte, error) { return nil, nil }
-
-func (nopAddressCodec) BytesToString(_ []byte) (string, error) { return "", nil }

client/v2/autocli/config/config.go

@@ -114,7 +114,7 @@ func writeConfigFile(configFilePath string, config *Config) error {
 	return os.WriteFile(configFilePath, b, 0o600)
 }
 
-// readConfig reads values from client.toml file and unmarshalls them into ClientConfig
+// readConfig reads values from client.toml file and unmarshals them into ClientConfig
 func readConfig(configPath string, v *viper.Viper) (*Config, error) {
 	v.AddConfigPath(configPath)
 	v.SetConfigName("client")