Replaced function insertSyntax #2
Conversation
|
With which browsers have you seen this error? |
|
Chrome on Windows. No error, just nothing happens - the link is not included in the text area. There is an open issue by someone else about exactly this behavior. |
src/upload.js
Outdated
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
What is the motivation behind all this empty lines?
src/upload.js
Outdated
| } | ||
|
|
||
| if(text){ | ||
| text = '|' + text; // use text as image label |
There was a problem hiding this comment.
This is not primarily intended for images, but for documents in general. Could you adjust that comment?
|
For the record: The alternative to merging this would be to replace the calls to However, this pull request provides a nice little extra feature and we should therefore go forward with it. |
|
thanks for the fast response. The caret seems to be working fine in IE11. What does not work, though, is the label for the uploaded file. This is likely because once IE loses focus during drag-and-drop, the selection is unselected. Insertion still works without errors, just without the label-functionality. |
|
Awesome, thanks :) |
I have had problems with the insertSyntax function. It worked only if no text edit was done.
Now I have rewritten the function. It looks similar to dokuwiki's own n insertTags function.
It even allows you to mark text, which then will be used as the image title.