Skip to content

Commit 929111f

Browse files
carmoccalantiga
authored andcommitted
Trigger TPU tests if [TPU] is in the PR title
1 parent 7aea1c6 commit 929111f

File tree

3 files changed

+5
-41
lines changed

3 files changed

+5
-41
lines changed

.github/checkgroup.yml

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -104,25 +104,6 @@ subprojects:
104104
# checks:
105105
# - "pytorch-lightning (IPUs)"
106106

107-
# TODO: since this job has intermittent availability, it cannot be required
108-
#- id: "pytorch-lightning: TPU workflow"
109-
# paths:
110-
# - ".actions/**"
111-
# - ".github/workflows/tpu-tests.yml"
112-
# - "dockers/base-xla/*"
113-
# - "requirements/fabric/**"
114-
# - "src/lightning_fabric/**"
115-
# - "tests/tests_fabric/**"
116-
# - "requirements/pytorch/**"
117-
# - "src/pytorch_lightning/**"
118-
# - "tests/tests_pytorch/**"
119-
# - "pyproject.toml" # includes pytest config
120-
# - "!requirements/*/docs.txt"
121-
# - "!*.md"
122-
# - "!**/*.md"
123-
# checks:
124-
# - "test-on-tpus"
125-
126107
- id: "fabric: Docs"
127108
paths:
128109
- "src/lightning/fabric/**"

.github/workflows/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
| .azure-pipelines/ipu-tests.yml | Run only IPU-specific tests. | IPU |
1111
| .azure-pipelines/gpu-tests-pytorch.yml | Run all CPU and GPU-specific tests, standalone, and examples. Each standalone test needs to be run in separate processes to avoid unwanted interactions between test cases. | GPU |
1212
| .azure-pipelines/gpu-benchmark.yml | Run speed/memory benchmarks for parity with pure PyTorch. | GPU |
13-
| .github/workflows/tpu-tests.yml | Run only TPU-specific tests. | TPU |
13+
| .github/workflows/tpu-tests.yml | Run only TPU-specific tests. Requires that the PR title contains '\[TPU\]' | TPU |
1414

1515
- \*Accelerators used in CI
1616

.github/workflows/tpu-tests.yml

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3,25 +3,8 @@ name: Test PyTorch - TPU
33
on:
44
push:
55
branches: [master, "release/*"]
6-
pull_request_target:
6+
pull_request: # TODO: set to target later
77
branches: [master, "release/*"]
8-
types: [opened, reopened, ready_for_review, synchronize] # added `ready_for_review` since draft is skipped
9-
paths:
10-
- ".actions/**"
11-
- ".github/workflows/tpu-tests.yml"
12-
- "dockers/base-xla/*"
13-
- "requirements/fabric/**"
14-
- "src/lightning/fabric/**"
15-
- "src/lightning_fabric/*"
16-
- "tests/tests_fabric/**"
17-
- "requirements/pytorch/**"
18-
- "src/lightning/pytorch/**"
19-
- "src/pytorch_lightning/*"
20-
- "tests/tests_pytorch/**"
21-
- "pyproject.toml" # includes pytest config
22-
- "!requirements/*/docs.txt"
23-
- "!*.md"
24-
- "!**/*.md"
258

269
concurrency:
2710
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref }}
@@ -39,12 +22,12 @@ defaults:
3922
jobs:
4023
test-on-tpus:
4124
runs-on: ubuntu-22.04
42-
if: github.event.pull_request.draft == false
25+
# run only when merged to master or the PR title contains '[TPU]'
26+
if: ${{ github.event.pull_request.merged == true || contains(github.event.pull_request.title, '[TPU]') }}
4327
env:
4428
PYTHON_VER: 3.8
4529
strategy:
46-
fail-fast: true
47-
max-parallel: 1 # run sequential
30+
fail-fast: false
4831
matrix:
4932
# TODO: add also lightning
5033
pkg-name: ["fabric", "pytorch"]

0 commit comments

Comments
 (0)