You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there a design reason that leftover unknown keyword arguments can't be raised as an error?
I don't recall if this was an intentional decision I made adhering too closely to Postel's Law, or ease/laziness. Either way, I now feel strongly this was the wrong decision :-) Changing this to be explicit would be a big improvement, though may require a semver bump.
I'd love to see it happen, in addition to real, strict MyPy support for this project. I'd be happy to review contributions, and or grant access to the project to you or others to help accomplish this.
Great, I've been on a bit of a type-hinting-bandwagon-spree lately so I'll see if I find time for this next weekend :) I'll make 2 separate PRs for it!
When passing additional, or misspelled, keyword arguments to
CORS
, and probably elsewhere, they are silently ignored.This means that a
CORS(app, rigins=["mydomain.com"], send_wildcard=True)
would produce false positive*
wildcards for any domain.Is there a design reason that leftover unknown keyword arguments can't be raised as an error?
The text was updated successfully, but these errors were encountered: