Skip to content

Fix flaky TestSchedulerShutdown_FrontendLoop #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Fix flaky TestSchedulerShutdown_FrontendLoop #6729

merged 1 commit into from
May 13, 2025

Conversation

SungJin1212
Copy link
Member

@SungJin1212 SungJin1212 commented May 2, 2025 •
edited
Loading

This PR fixes the flaky TestSchedulerShutdown_FrontendLoop test. It should ensure the scheduler has been terminated.
Failed test logs:

--- FAIL: TestSchedulerShutdown_FrontendLoop (0.00s)
    scheduler_test.go:282: 
        	Error Trace:	/__w/cortex/cortex/pkg/scheduler/scheduler_test.go:282
        	Error:      	Should be true
        	Test:       	TestSchedulerShutdown_FrontendLoop
FAIL

Which issue(s) this PR fixes:
Fixes #6724

Checklist

  • Tests updated
  • [NA] Documentation added
  • [NA] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@SungJin1212
Fix flaky TestSchedulerShutdown_FrontendLoop
0c9ec48 
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 requested a review from dsabsay May 7, 2025 02:12
dsabsay
dsabsay approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@dsabsay dsabsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

yeya24
yeya24 approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yeya24 yeya24 merged commit 4c9e964 into cortexproject:master May 13, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsabsay dsabsay dsabsay approved these changes

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
size/XS type/flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Top flaky tests on master by frequency
3 participants
@SungJin1212 @dsabsay @yeya24