Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all max async concurrency #6268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SungJin1212
Copy link
Contributor

@SungJin1212 SungJin1212 commented Oct 15, 2024

Change all max-async-concurrency default values 50 to 3
it includes
-blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency
-blocks-storage.bucket-store.index-cache.redis.max-async-concurrency
-blocks-storage.bucket-store.chunks-cache.memcached.max-async-concurrency
-blocks-storage.bucket-store.chunks-cache.redis.max-async-concurrency

FYI. max-async-concurrency default values of the multilevels (index, chunks) are already 3.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@dosubot dosubot bot added the storage/blocks Blocks storage engine label Oct 15, 2024
@harry671003
Copy link
Contributor

Could you help me understand why the defaults are changed from 50 to 3?

@SungJin1212
Copy link
Contributor Author

@harry671003
50 goroutines taking a lot of CPUs as mentioned (comment) in #6249.
And I got the comment to change all async concurrency in #6265.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 15, 2024
@SungJin1212
Copy link
Contributor Author

@yeya24
Could you take review it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size/M storage/blocks Blocks storage engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants