Skip to content

Create cortex_reduced_resolution_histogram_samples_total metric #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alanprot
Copy link
Member

What this PR does:
Create a new metric, cortex_reduced_resolution_histogram_samples_total, to track the number of native histogram samples that had to be reduced because the number of buckets exceeded the allowed limit.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

… resolution reduced

Signed-off-by: alanprot <alanprot@gmail.com>
Signed-off-by: alanprot <alanprot@gmail.com>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

@alanprot alanprot merged commit 39a168d into cortexproject:master Aug 30, 2024
16 checks passed
danielblando pushed a commit to danielblando/cortex that referenced this pull request Sep 3, 2024
…rtexproject#6182)

* Create new metric to count how many native histrogram samples had the resolution reduced

Signed-off-by: alanprot <alanprot@gmail.com>

* changelog

Signed-off-by: alanprot <alanprot@gmail.com>

---------

Signed-off-by: alanprot <alanprot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants