Implement max bucket limit and automatic resolution reduction #6104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
CharlieTLe
approved these changes
Jul 22, 2024
pkg/util/validation/limits.go
Outdated
| @@ -722,6 +725,11 @@ func (o *Overrides) EnforceMetadataMetricName(userID string) bool { | |||
| return o.GetOverridesForUser(userID).EnforceMetadataMetricName | |||
| } | |||
|
|
|||
| // MaxNativeHistogramBuckets. | |||
There was a problem hiding this comment.
nit: Can we add comment on what this function is doing?
There was a problem hiding this comment.
Addressed in latest commit.
pkg/util/validation/validate.go
Outdated
| @@ -52,6 +52,9 @@ const ( | |||
| exemplarLabelsTooLong = "exemplar_labels_too_long" | |||
| exemplarTimestampInvalid = "exemplar_timestamp_invalid" | |||
|
|
|||
| // Native Histogram specific validation reasons | |||
| nativeHistogramBucketsExceeded = "native_histogram_buckets_exceeded" | |||
There was a problem hiding this comment.
Can we make the error more specific like nativeHistogramBucketCountLimitExceeded?
There was a problem hiding this comment.
Addressed in latest commit.
Signed-off-by: Ben Ye <benye@amazon.com>
CharlieTLe
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Introduce a new limit
max_native_histogram_bucketswhich limits maximum number of buckets of a native histogram sample. When exceeding the limit, Distributor will try to reduce the ingested histogram resolution until it is within the buckeet limit or the resolution can't be reduced anymore.Which issue(s) this PR fixes:
Fixes #6092
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]