Ignore not found errors when compacting users #4870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Protasio <approtas@amazon.com>
alanprot
force-pushed
the
ignore-not-found
branch
from
8cfa15b to
27b0215
Compare
yeya24
reviewed
Sep 19, 2022
alvinlin123
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alan Protasio approtas@amazon.com
What this PR does:
Ignore not found errors when compacting users.
#4805 introduced a new markers that is being called on the shuffle sharding grouper and its expected to receive 404, causing
thanos_objstore_bucket_operation_failures_totalmetric to spike.With this change, we should not count 404s towards
thanos_objstore_bucket_operation_failures_total.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]