Modifying https://github.com/cortexproject/cortex/pull/4422 to retry only for GET Requests #4840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnateja325
force-pushed
the
unary-call-alert-manager-for-GET-requests
branch
from
85bee4c to
f3c0d0f
Compare
alanprot
reviewed
Aug 23, 2022
alanprot
reviewed
Aug 23, 2022
krishnateja325
force-pushed
the
unary-call-alert-manager-for-GET-requests
branch
from
f3c0d0f to
8d3ac48
Compare
3 tasks
krishnateja325
force-pushed
the
unary-call-alert-manager-for-GET-requests
branch
3 times, most recently
from
d388ff7 to
e9319eb
Compare
Added a check to retry only when the request is a GET request and isUnaryReadPath |
qinxx108
reviewed
Sep 8, 2022
krishnateja325
force-pushed
the
unary-call-alert-manager-for-GET-requests
branch
3 times, most recently
from
aeb4bea to
d4198ca
Compare
qinxx108
approved these changes
Sep 8, 2022
danielblando
approved these changes
Sep 8, 2022
alvinlin123
approved these changes
Sep 9, 2022
alvinlin123
reviewed
Sep 9, 2022
krishnateja325
force-pushed
the
unary-call-alert-manager-for-GET-requests
branch
from
d4198ca to
1ea27ef
Compare
… AlertManager UnaryPath GET Requests on next replica if one fail. Signed-off-by: Krishna Teja Puttagunta <krishtez@amazon.com>
krishnateja325
force-pushed
the
unary-call-alert-manager-for-GET-requests
branch
from
1ea27ef to
8ea073f
Compare
Signed-off-by: Krishna Teja Puttagunta <krishnateja325@gmail.com>
alanprot
approved these changes
Sep 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes Retrying AlertManager UnaryPath Requests on next replica if one fail #4422
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]