Create OpenTelemetry Bridge for Tracing #4834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromeinsf
reviewed
Aug 19, 2022
| # enhance exporter with attributes for specific exporter. Currently only | ||
| # awsxray is supported | ||
| # CLI flag: -tracing.otel.exporter-type | ||
| [exporter_type: <string> | default = ""] |
There was a problem hiding this comment.
does default "" mean awsxray?
There was a problem hiding this comment.
No.. defaults mean "generic"...
What we do here for some destinations we need to configure the exporter a little different. For instance, if the end backend is X-Ray we need to generate the traceIds in a specific format.
I believe for the majority of the backends it will work with this type set to empty.
alanprot
force-pushed
the
otel-bridge
branch
3 times, most recently
from
cbec84e to
9c6e384
Compare
alvinlin123
reviewed
Aug 23, 2022
alvinlin123
reviewed
Aug 23, 2022
Signed-off-by: Alan Protasio <approtas@amazon.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
Signed-off-by: Alan Protasio <approtas@amazon.com>
alvinlin123
reviewed
Aug 23, 2022
alvinlin123
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Create OpenTelemetry Bridge for Tracing following https://opentelemetry.io/docs/migration/opentracing/
With this PR we can now export Cortex traces to multiples destinations as, for example, AWS X-RAY:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]