Add config option to omit exporting rule_group label on ruler metrics #4571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
|
Please add a CHANGELOG entry. |
|
CI has failed twice on a test believed to be flaky #4546 |
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Would that be a blocker? |
pracucci
approved these changes
Dec 2, 2021
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…cortexproject#4571) * add config option to omit exporting rule_group label on ruler metrics Signed-off-by: Zahari Dichev <zaharidichev@gmail.com> * add changelog entry Signed-off-by: Zahari Dichev <zaharidichev@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR introduces a config option for the ruler, which allows it to avoid exporting the
rule_grouplabel onrule evaluation metrics.
Which issue(s) this PR fixes:
Fixes #4566
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]Signed-off-by: Zahari Dichev zaharidichev@gmail.com