Chore: Use middleware package from dskit #4471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
chore/use-dskit-middleware
branch
from
8304206 to
aa99a2e
Compare
bboreham
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
lgtm but I might suggest moving these functions into https://github.com/weaveworks/common/blob/master/middleware/grpc_instrumentation.go since they are effectively the client side of what is already there.
aknuds1
force-pushed
the
chore/use-dskit-middleware
branch
from
aa99a2e to
b4310d9
Compare
@bboreham that change would have to happen in dskit though, right? As such, it's outside of the scope of this PR. If we want to make that change, it should be easy to fix up Cortex after. |
aknuds1
force-pushed
the
chore/use-dskit-middleware
branch
from
b4310d9 to
7c874b6
Compare
aknuds1
force-pushed
the
chore/use-dskit-middleware
branch
from
7c874b6 to
629fb6b
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/use-dskit-middleware
branch
from
629fb6b to
1529953
Compare
pracucci
approved these changes
Oct 13, 2021
3 tasks
2 tasks
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Manish Kumar Gupta <manishkg@microsoft.com>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Use middleware package from dskit.
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]