Memberlist now forwards only changes, not full original received message #4419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pstibrany
changed the title
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
joe-elliott
approved these changes
Aug 13, 2021
3 tasks
pracucci
approved these changes
Aug 16, 2021
3 tasks
bboreham
reviewed
Sep 2, 2021
| @@ -19,6 +19,7 @@ | |||
| * Users only have control of the HTTP header when Cortex is not frontend by an auth proxy validating the tenant IDs | |||
| * [CHANGE] Some files and directories created by Mimir components on local disk now have stricter permissions, and are only readable by owner, but not group or others. #4394 | |||
| * [CHANGE] Compactor: compactor will no longer try to compact blocks that are already marked for deletion. Previously compactor would consider blocks marked for deletion within `-compactor.deletion-delay / 2` period as eligible for compaction. #4328 | |||
| * [CHANGE] Memberlist: forward only changes, not entire original message. #4419 | |||
There was a problem hiding this comment.
Why is this listed as a breaking change?
There was a problem hiding this comment.
It’s a change, but not a breaking one. I guess it could be moved under BUGFIX, as it fixes problem with messages looping in the gossip network forever.
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…age (cortexproject#4419) * Memberlist now forwards only changes, not full original received message. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * CHANGELOG.md entry Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Ignore linter here. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR modifies memberlist KV client such that when it receives message via
NotifyMsg, which changes current state of the KV store, it doesn't forward entire message, but only sub-message with changes. This helps in some clusters to get rid of unwanted messages with tombstones, which currently DO generate a change (this is bug, PR incoming) and then retransmit even the part of message that hasn't changed anything. This can in some situations bring back ingester instances in the ring, which should be long forgotten.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]