Skip to content

fix potential resolver error in production #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sstoner
Copy link

@sstoner sstoner commented Jun 1, 2021

What this PR does:
the specified resolver is a potential error

2021/05/31 07:08:50 [error] 20#20: *17204171 could not be resolved (110: Operation timed out), client: 192.168.2.24, server: , request: "GET /ruler/rules HTTP/1.1"

Which issue(s) this PR fixes:

#671 (comment)

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: vanceli <vanceli@tencent.com>
Copy link
Contributor

@stevesg stevesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this suggestion, though I don't understand the problem enough to give feedback. My initial feeling is that changing this might work for some people, and break for others.

Could you elaborate on why this change is needed for your environment? (Just for my understanding, thanks!)

@sstoner
Copy link
Author

sstoner commented Jun 4, 2021

Thanks for this suggestion, though I don't understand the problem enough to give feedback. My initial feeling is that changing this might work for some people, and break for others.

This will not break for others. After removed resolver, nginx's DNS requests will be forward to this instance's resolv.conf.

In contrast, when we set this resolver, it may be a misconfiguration for some users for the custom environment and as what this blog mentioned by tomwilkie, we also occur this problem in production.

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We shouldn't force to a specific resolver but use the default one. If anyone needs a custom config, then they can override it.

Copy link
Contributor

@stevesg stevesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked this part:

resolving the resolver is well, bad form

@bboreham
Copy link
Contributor

The whole k8s directory was removed by #4268 so I don't think we need this now.
Maybe there is comparable config in one of the helm charts?

@bboreham bboreham closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants