Make iterations metric per rule_group #4121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
add-per-group-metrics
branch
from
ed81530 to
7ea009a
Compare
|
The reason we didn't do that before is because when we first made this change, upstream Prometheus metric didn't have a |
|
Can you please rebase against master to pull in #4137 and move the changelog entry to the top? |
pstibrany
reviewed
Apr 28, 2021
pstibrany
approved these changes
Apr 28, 2021
The upstream metric got a new label after this change was done. When it was originally added 9mo ago: cortexproject@27e2d46 When upstream changed 8mo ago: prometheus/prometheus#7823 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
add-per-group-metrics
branch
from
a5d7754 to
ae3ae82
Compare
pracucci
reviewed
Apr 29, 2021
There was a problem hiding this comment.
@gouthamve Could you open a PR with the CHANGELOG entry for this PR change, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I have a feeling we didn't do
rule_groupfor those metrics on purpose. The metric output doesn't have the iterations metrics anymore.