Ingester can now flush only specified users. #4073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Apr 13, 2021
pkg/ingester/ingester_v2.go
Outdated
| }() | ||
| } | ||
|
|
||
| const waitParam = "wait" |
There was a problem hiding this comment.
[nit] I would define it close to the tenant param (if we'll keep it), given they both apply to the same API endpoint.
There was a problem hiding this comment.
I suggest we keep it. Moving to tenantParam.
|
Thank you for review, I've addressed your comments now. |
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pstibrany
force-pushed
the
ingester-flush-tenants
branch
from
b1d4e81 to
5310d07
Compare
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pracucci
approved these changes
Apr 14, 2021
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR adds
tenantparameter to/flushhandler. When used, only specific tenant is flushed and only this tenants' blocks are shipped.tenantparameter may be used multiple times to specify many tenants at once.This PR also adds
waitparameter to/flushmethod, which makes the method synchronous -- it only returns when compact + ship cycle have finished. Note that/flushstill only returns 204, no matter the result of compaction or shipment.These two enhancements are only available when using blocks storage.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]