Allow testing of alertmanager gRPC replication in multitenant_test.go. #3958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a fake implementation of the alertmanager ClientPool to connect together the alertmanager instances in the multitenant_test.go unit test. This allows testing of the replication logic without relying on doing do at integration test level, and without having the weight of the gRPC server running. Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
stevesg
commented
Mar 16, 2021
| // For RF=3 1 -> 2 -> 4 = Total 6 merges | ||
| nFanOut := tt.replicationFactor - 1 | ||
| nMerges := nFanOut + (nFanOut * nFanOut) | ||
| assert.Equal(t, float64(nMerges), metrics.GetSumOfCounters("cortex_alertmanager_partial_state_merges_total")) |
There was a problem hiding this comment.
Note I've fixed the names of these metrics by adding the cortex_ - is my assumption correct?
3 tasks
pracucci
approved these changes
Mar 17, 2021
| // For RF=3 1 -> 2 -> 4 = Total 6 merges | ||
| nFanOut := tt.replicationFactor - 1 | ||
| nMerges := nFanOut + (nFanOut * nFanOut) | ||
| assert.Equal(t, float64(nMerges), metrics.GetSumOfCounters("cortex_alertmanager_partial_state_merges_total")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Allow testing of alertmanager gRPC replication in multitenant_test.go.
Use a fake implementation of the alertmanager ClientPool to connect
together the alertmanager instances in the multitenant_test.go unit
test. This allows testing of the replication logic without relying on
doing do at integration test level, and without having the weight of the
gRPC server running.
Checklist
Tests updatedDocumentation addedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]