Skip to content

(1.7 release) Handle the case of large step causing single pt extents (#3818) #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

khaines
Copy link
Contributor

@khaines khaines commented Feb 16, 2021

  • Handle the case of large step causing single pt extents

We noticed that we were ignoring samples if the step is 24h and this
fixes it.

Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com

  • Handle the case of start == end better

Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com

  • Address feedback

Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com
(cherry picked from commit e10ccda)

…t#3818)

* Handle the case of large step causing single pt extents

We noticed that we were ignoring samples if the step is 24h and this
fixes it.

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Handle the case of start == end better

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Address feedback

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
(cherry picked from commit e10ccda)
@khaines khaines changed the title Handle the case of large step causing single pt extents (#3818) (1.7 release) Handle the case of large step causing single pt extents (#3818) Feb 16, 2021
@khaines khaines merged commit b18ded7 into cortexproject:release-1.7 Feb 17, 2021
@khaines khaines deleted the khaines/pick-3818-large-extents-with-single-value branch February 17, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants