Include parameter name when returning HTTP 400 for query_range API #3703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
alvinlin123
force-pushed
the
issue-3699-better-error-message-for-query-range
branch
2 times, most recently
from
0c3ca56 to
8cfe522
Compare
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
alvinlin123
force-pushed
the
issue-3699-better-error-message-for-query-range
branch
from
8cfe522 to
daaf429
Compare
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
pstibrany
approved these changes
Jan 19, 2021
Signed-off-by: Marco Pracucci <marco@pracucci.com>
simonswine
pushed a commit
to simonswine/cortex
that referenced
this pull request
Jan 19, 2021
…ortexproject#3703) * Include parameter name when returning HTTP 400 for query_range API Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Add param name even if error is not rpc error Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Fix typo in CHANGELOG.md Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Update CHANGELOG.md Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add parameter name to HTTP 400 message returned to the user for self-debugging.
Which issue(s) this PR fixes:
Fixes #3699
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]