Enforced -querier.max-query-lookback in the query-frontend for range queries #3458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Nov 4, 2020
…queries Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
Thanks @pstibrany for your thoughtful review. I've addressed all comments! |
pracucci
force-pushed
the
enforce-max-query-lookback-in-query-frontend
branch
from
aa3ab21 to
254d437
Compare
yeya24
approved these changes
Nov 4, 2020
Sure you can! |
ranton256
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In the PR #3452 I've introduced
-querier.max-query-lookbackbut I've intentionally skipped enforcing the limit in the query-frontend, in order to keep the change set smaller. In this PR I'm enforcing it in the query-frontend too, for range queries.The main benefit of enforcing it in the query-frontend too is to reduce the number of query range requests enqueued for a tenant, if such queries cover a range outside the max lookback. Without this PR, the limit would be enforced anyway in the querier, but we may end up with a large number of splitted queries in the query-frontend/query-scheduler queue which would be noop once executed in the querier.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]