Added flag to explicitly enable zone-awareness replication and added store-gateway support #3200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
commented
Sep 18, 2020
| @@ -402,72 +407,6 @@ func (r *Ring) Collect(ch chan<- prometheus.Metric) { | |||
| ) | |||
| } | |||
|
|
|||
| // Subring returns a ring of n ingesters from the given ring. If the subring can't be built | |||
| // (ie. because there are not enough instances) then it returns the full ring. | |||
| func (r *Ring) Subring(key uint32, n int) ReadRing { | |||
There was a problem hiding this comment.
Forgot to remove it in #3090, so removing it now.
|
@pstibrany Thanks for your review. Could you check it again, please? |
pstibrany
approved these changes
Sep 18, 2020
…store-gateway support Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
…r the replication set Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
add-flag-to-explicitly-enable-zone-awareness
branch
from
e6a9612 to
21483eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR:
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]