Skip to content

exclude generated protos from PR size bot #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jtlisi
Copy link
Contributor

@jtlisi jtlisi commented Mar 7, 2020

What this PR does:

This excludes all generated proto files from the Pull Request Size bot we run on this repo. #2226 is marked XXL despite most of the LOC being generated files. This PR will ensure the PR Bot ignores generated protos.

Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit 44b5ba9 into cortexproject:master Mar 7, 2020
@pracucci pracucci mentioned this pull request Mar 9, 2020
3 tasks
@jtlisi jtlisi deleted the 20200306_pr_size_exclude_genprotos branch March 9, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants