Fix ingester_memory_series/users metrics for TSDB storage #1982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
force-pushed
the
fix-ingester-memory-series-for-blocks-storage
branch
from
307a4bc to
0648256
Compare
gouthamve
approved these changes
Jan 15, 2020
pstibrany
approved these changes
Jan 15, 2020
pracucci
pushed a commit
that referenced
this pull request
Jan 15, 2020
* Update queriedSeries and queriedSamples metrics in v2Query. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Increment number of users when creating new TSDB. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Use length of slices to update metrics. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Update CHANGELOG.md Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Removed memUsers.Inc() in favor of PR #1982. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Removed mention of cortex_ingester_memory_users from CHANGELOG.md Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * One more small fix to CHANGELOG.md. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pracucci
force-pushed
the
fix-ingester-memory-series-for-blocks-storage
branch
from
0648256 to
bfeb4be
Compare
codesome
approved these changes
Jan 15, 2020
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
fix-ingester-memory-series-for-blocks-storage
branch
from
bfeb4be to
b2569e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I've implemented the following two metrics for TSDB storage:
cortex_ingester_memory_seriescortex_ingester_memory_usersI've also moved the 4 metrics globally registered in
user_state.goto theingesterMetricsstruct to ease testing.This PR complements #1981 by @pstibrany.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]