Reduce memory usage from ingester Push() errors #1922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryan Boreham <bryan@weave.works>
Signed-off-by: Bryan Boreham <bryan@weave.works>
…tion It's more efficient to defer constructing the httpgrpc error until the end, because we only report the last error out of possibly hundreds. Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
smaller-ingester-push-errors
branch
from
dd8f7c4 to
d4cd56c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1301
There is quite a lot of refactoring here, pulling out various things into helper functions in a new file
errors.go. Also I moved a couple of places that the discarded samples metric is incremented for consistency.I'm not very clear why we need "httpgrpc" at all here, as
Push()is only called over gRPC, but left that for another day.Benchmark before:
after: